dex-k8s-authenticator icon indicating copy to clipboard operation
dex-k8s-authenticator copied to clipboard
verified publisher icon mintel

Added Annotations section to Deployment template

Open VF-mbrauer opened this issue 5 years ago • 6 comments

To make it possible to have an annotations section defined which we can fill with data. Right now it is static data and just filled with checksum/config: This makes it more flexible to give also other customized key/value pairs defined there.

VF-mbrauer avatar Oct 22 '20 19:10 VF-mbrauer

@VF-mbrauer - just wondering if you saw my reply or not, and whether these changes are still required?

Thanks

nabadger avatar Nov 11 '20 08:11 nabadger

I would personally like to see this merged in. I need annotations to allow connecting to hashicorp vault.

jengo avatar Feb 23 '21 21:02 jengo

@VF-mbrauer - just wondering if you saw my reply or not, and whether these changes are still required?

Thanks

Hi @nabadger, apologize for the late reply. I found also another way of implementation on our side via Admission Controller functionality, but I still see this feature as important as for users not implementing this that way I mentioned. Therefore this should be implemented the way we discussed already. Thanks.

VF-mbrauer avatar Feb 23 '21 21:02 VF-mbrauer

@VF-mbrauer would you be able to rename this to podAnnotations? If not I can do this in a different MR and merge it in :)

nabadger avatar Mar 05 '21 08:03 nabadger

Hi @nabadger, yes of course. Feel free to amend for me and get it merged. Then we can finally close this thread. Thanks.

VF-mbrauer avatar Jun 16 '21 22:06 VF-mbrauer

@nabadger Any news here. Did you amend and merged that in the meantime?

VF-mbrauer avatar Jan 14 '22 00:01 VF-mbrauer