minosgalanakis

Results 19 comments of minosgalanakis

Just to confirm the proposed checkboxes should look like Please remove add/remove strikethrough `~~` as appropriate, add any text or justification if required and any relevant links to the end...

> I don't understand: “the gatekeeper has confirmed everything is ok” is already conveyed by the fact that the gatekeeper pressed the merge button. I thought the point was to...

Apologies I was not very clear PyGithub is using said python bindings to issue the graphQL querries for the information. I am more than happy to ditch github cli, if...

> * **changelog** provided, ~not required~, ~covered~ . Link --> #XYZ The only thing I would add is a commentary and an example eg. Since this is a new system...

I have updated the [shift2 release proccess](https://confluence.arm.com/pages/resumedraft.action?draftId=710592630&draftShareId=48f9a515-b52d-41d6-9329-bb0b5090aed4&) to include the sha256sum generation.

Looks good to me with one minor question. I am not quite certain of the interger range the generation is bound to. The assumption is that rng is returning an...

Having looked at the use of accessors in programs the following are being used. ### RSA ~~~~~~ rsa_encrypt: rsa_decrypt: rsa.MBEDTLS_PRIVATE(len) rsa_verify.c rsa.MBEDTLS_PRIVATE(N) rsa.MBEDTLS_PRIVATE(E) rsa.MBEDTLS_PRIVATE(len) ~~~~~~ The estimation is that not...

Fully recreated the commit from fresh base, replaying the choices made in the previous for-review revision https://github.com/Mbed-TLS/mbedtls/commit/2a2c4cbd5d6553f1e33d98cb6d1598a8a08b3024 ### Notes to reviewers - I have structured the commits per components, making...

> Looks good to me at [bf47cf7](https://github.com/Mbed-TLS/mbedtls/commit/bf47cf74374f8ae60d948ac1fac313a605afd3e9), but please remove [3d1bf49](https://github.com/Mbed-TLS/mbedtls/commit/3d1bf4977fdb184a0df4c9a98e805b5930269c57) where [I realize I made a mistake](https://github.com/Mbed-TLS/mbedtls/pull/8226#discussion_r1701403271) (sorry about that). Thats ok, that is precicely they were placed in...