phpunit-mink
phpunit-mink copied to clipboard
minkphp
Added PhantomJsDriverFactory to project
Hello,
Based on the discussion in #74 I tried to make it work. It works for me so far, but I only tested taking screenshots and getStatusCode(). But as I asume the mink driver is already tested itself, everything should work.
This implemenation asumes phantom.js is already running.
I also added the new Factory to the DriverFactoryRegistry in DIContainer to make it useable out of-the-box. If there is anything I missed or misunderstood please let me know.
Gosh this scruntnizer doesn't like me.
You can configure coding style checks in your IDE to detect CS issues before making a commit.
Please reply with inline comment to each fixed thing, because GitHub doesn't send notifications when you've add new commits.
Another solution is to post a single comment saying you have updated the PR (this sends us a single notif)
Another solution is to post a single comment saying you have updated the PR (this sends us a single notif)
Ha. The inline comments replies have hidden purpose: this way PR author knows what has been addressed and what wasn't. I've seen several times, that when multiple things needs to be done some of them can be forgotten.
Thank you for you valuable feedback @stof and @aik099. I'll do my best to clean the coding style.
Sorry, no time. It's just code style missing. I am not aware of which style it is. I guess PEAR ?
See https://github.com/minkphp/phpunit-mink/blob/master/CONTRIBUTING.md#checking-coding-standard-violations for instructions how to configure code style checks using code style used by this library.
Any update on this? I would really appreciate having the phantomJS driver available.
Just waiting for the moment, when PR author's will have time to spare to address all review comments.