phpunit-mink icon indicating copy to clipboard operation
phpunit-mink copied to clipboard
verified publisher icon minkphp

Inline "SessionFactory" class

Open aik099 opened this issue 10 years ago • 1 comments

After #12 is implemented the session driver creation is moved away from SessionFactory class to the corresponding driver factories. And the SessionFactory only has 1 line long method called createSession: phpunitmink_smallsessionfactory

The only class using that method is IsolatedSessionStrategy that can create/start sessions. I propose, that we:

  • remove ISessionFactory interface
  • remove SessionFactory class
  • inline SessionFactory::createSession method into IsolatedSessionStrategy::session method

aik099 avatar Mar 21 '15 08:03 aik099

:+1:

stof avatar Mar 22 '15 15:03 stof