docs icon indicating copy to clipboard operation
docs copied to clipboard

Add automatic soft isolation to Session docs

Open j4m3s opened this issue 10 years ago • 9 comments

Includes reference to Selenium limitation which results in cookies bleeding between multi-domain scenarios discussed in minkphp/docs#51

j4m3s avatar Feb 26 '15 22:02 j4m3s

Your rST syntax is invalid (see the travis build)

stof avatar Feb 27 '15 08:02 stof

Thanks for flagging those - I didn't get a notification about the failed build, but have checked this one manually and the syntax seems ok now. I assumed the syntax was ok when the github preview worked. Dangerous to assume! I did try pasting the whole file into the rST validator at https://www.tele3.cz/jbar/rest/rest.html to make sure I was now correct, but it came up with a pile of validation errors in parts of the file I hadn't changed so I just gave it a try against Travis (twice). Apologies for the multiple attempts.

I've removed the reference to Scenarios - I'm afraid my use of Mink through Behat alone led me to another assumption... The doc now refers to tests instead.

j4m3s avatar Mar 03 '15 15:03 j4m3s

@j4m3s you don't receive emails when the PR status is updated. This only appears on the PR after it is created or updated (the build takes a few minutes)

stof avatar Mar 03 '15 15:03 stof

@stof I'm confused here. In issue #51 you said these were the docs to update. Are you suggesting that the answer to my question 'am I right in thinking that scenarios are "soft isolated" by default' should not be documented here after all?

The whole thread was born from cookies bleeding between scenarios so if Mink knows nothing about scenarios and does nothing automatically isolate it seems I'm in the wrong place entirely.

j4m3s avatar Mar 03 '15 16:03 j4m3s

Are you suggesting that the answer to my question 'am I right in thinking that scenarios are "soft isolated" by default' should not be documented here after all?

You're correct @j4m3s , because scenarios are Behat/MinkExtension terminology. Mink docs shouldn't mention anything of Behat.

aik099 avatar Mar 03 '15 17:03 aik099

Understood, thanks - let me revise the pull request.

Is there somewhere that I should document the cookie-bleed risk? MinkExtension maybe? I have to admit I struggle somewhat with the Behat 3 readthedocs.

j4m3s avatar Mar 03 '15 20:03 j4m3s

I've made something of a pig's ear of this PR - multiple commits while we ground out the right text, plus several fixing the rst syntax. Once you're happy with the content let me know if you'd like me to raise a new PR with a single commit.

j4m3s avatar Mar 03 '15 20:03 j4m3s

Looks good, @j4m3s . @stof , any corrections before merge?

aik099 avatar Mar 03 '15 22:03 aik099

FYI I wrote some words for MinkExtension here: https://github.com/Behat/MinkExtension/pull/292 that documents how @insulated works with Behat-MinkExtension on its way to calling Mink stuff. (obviously not to go in Mink doc, since that is a MinkExtension feature)

It would be nice to have some of the words in this PR in the Mink doc, as it explains a bit more about what happens for reset vs stop in Mink.

phil-davis avatar Sep 21 '17 04:09 phil-davis