MinkSelenium2Driver icon indicating copy to clipboard operation
MinkSelenium2Driver copied to clipboard

Add a CI job running on PHP 8.5

Open stof opened this issue 1 month ago • 3 comments

stof avatar Nov 22 '25 12:11 stof

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 85.42%. Comparing base (d8b1d4e) to head (8576b11).

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #414   +/-   ##
=========================================
  Coverage     85.42%   85.42%           
  Complexity      184      184           
=========================================
  Files             1        1           
  Lines           501      501           
=========================================
  Hits            428      428           
  Misses           73       73           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Nov 22 '25 12:11 codecov[bot]

I guess there will be another PR to the test suite that will skip usage of the imagedestroy and curl_close functions on PHP > 8.0. Without this build for PHP 8.5 now fails.

aik099 avatar Nov 22 '25 18:11 aik099

The deprecation of imagedestroy has been fixed in https://github.com/minkphp/driver-testsuite/pull/107. The deprecation of curl_close will be fixed once https://github.com/instaclick/php-webdriver/pull/141 is merged and released.

stof avatar Nov 22 '25 18:11 stof