MinkSelenium2Driver icon indicating copy to clipboard operation
MinkSelenium2Driver copied to clipboard

Improve "Selenium2Driver::applyTimeouts" error handling for Selenium 3 support

Open aik099 opened this issue 1 year ago • 1 comments

Closes https://github.com/minkphp/MinkSelenium2Driver/issues/379

Added code remains uncovered by tests because we're testing on Selenium 2 only.

aik099 avatar Feb 18 '24 14:02 aik099

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (4ca4083) 90.19% compared to head (2fe6b36) 89.80%.

Files Patch % Lines
src/Selenium2Driver.php 50.00% 1 Missing :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #380      +/-   ##
============================================
- Coverage     90.19%   89.80%   -0.39%     
- Complexity      168      169       +1     
============================================
  Files             1        1              
  Lines           469      471       +2     
============================================
  Hits            423      423              
- Misses           46       48       +2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 18 '24 14:02 codecov[bot]

Thank you @stof . Merging.

aik099 avatar Jun 28 '24 09:06 aik099