MinkSelenium2Driver icon indicating copy to clipboard operation
MinkSelenium2Driver copied to clipboard

Update Syn to 0.15.0

Open zrpnr opened this issue 4 years ago • 0 comments

The Syn library has been under active development, and the current release is 0.15.0. MinkSelenium2Driver uses 0.0.3 currently. In 0.15.0 there was a fix for the deprecated which property. https://github.com/bitovi/syn/issues/180

This affects any sites that are running tests with keyPress events if, for example- they use the latest jQuery 3.6.0 that removed a shim for this property. https://github.com/jquery/jquery/pull/4765

There was discussion about updating Syn in:

  • https://github.com/minkphp/MinkSelenium2Driver/issues/279
  • https://github.com/minkphp/MinkSelenium2Driver/issues/20

The minified js in this PR comes from the v0.15.0 tag of https://github.com/bitovi/syn I added

options: {
  minify: true
},

to the export command in build.js and ran npm run build to produce dist/global/syn.js

In Selenium2Driver.php updated Syn to syn and updated the trigger function since the order of arguments has changed.

zrpnr avatar May 12 '21 00:05 zrpnr