Mink added pressKey, deprecated keyPress/keyDown/keyUp

Ref.: https://github.com/minkphp/MinkSelenium2Driver/pull/304#discussion_r246046293

that's not the same API than previously. After calling keyDown, your implementation already released the key.

I think we should rather add a new pressKey method in Mink, and deprecate these 3 methods. And the new version of the driver would then implement only pressKey.

And we should implement the new method in 1.x too The old implementation was not good anyway, as it was not actually pressing the key, but only triggering the JS actions (so the default behavior of pressing a key would not happen).

Jan 13 '19 22:01 oleg-andreyev

please also open a PR for the driver-testsuite repo to cover pressKey

Jan 14 '19 10:01 stof

@stof https://github.com/minkphp/driver-testsuite/pull/30

Sep 02 '19 12:09 oleg-andreyev

I recommend releasing all current features as 1.7.2 version and only then merging this PR which will force next release to be 1.8.0.

Sep 03 '19 18:09 aik099

@aik099 I’m okay 1.7.2 will just PR probably tomorrow

Sep 03 '19 21:09 oleg-andreyev

@aik099 I’m okay 1.7.2 will just PR probably tomorrow

@oleg-andreyev , according to #725 @greg-1-anderson is also wanting to help out with a PR. I'll let him do that.

Sep 04 '19 06:09 aik099

I took a swag at making an updated changelog in #786. If anyone wants to improve it, feel free; I am unfamiliar with the conventions used in this project, and just made my best effort based on previous entries.

Sep 04 '19 18:09 greg-1-anderson