Mink
Mink copied to clipboard
Add exist methods for button and select elements
Added exist methods for button and select elements
And I guess the getComputedStyle methods got in this PR by accident again, like they did with your previous PR?
@aik099 gah they did... mmmm.. I think I going to need to delete my Mink repo and refork. Will that cause any issues? will it break the other PR?
I think I must of pushed the getComputedStyle onto my fork's master.
Okay I rebased onto upstream/master to solve for this PR
I think I going to need to delete my Mink repo and refork.
I think instead you should be pulling upstream/master into your fork's grom358/origin and then rebasing PR on top of that.
I think I must of pushed the getComputedStyle onto my fork's master.
That's bad news.
Okay I rebased onto upstream/master to solve for this PR
Unfortunately GitHub says otherwise because it can't automatically merge this PR.
Okay I rebased onto upstream/master to solve for this PR
I guess you forgot to fetch upstream first, so using an outdated upstream/master
My upstream was set to Behat/Mink ... problem solved.
These duplicate scrutinizer errors are bogus.
@grom358 we don't consider duplications as failure conditions (because we know it's bogus in several places). the failure condition is for coding styles issues
@stof fixed the indenting issues... I had my editor on 2 space indents :S
Was there anything else required for this PR?
Maybe squash. @stof , do you see any other changes required before merging?
I have updated this PR for the 1.7 changes. Scrutinizer thinks code is duplicate but its not as far as I can tell. Just number of methods that look similar.