Mink icon indicating copy to clipboard operation
Mink copied to clipboard

Add exist methods for button and select elements

Open grom358 opened this issue 10 years ago • 12 comments

Added exist methods for button and select elements

grom358 avatar Jan 08 '15 07:01 grom358

And I guess the getComputedStyle methods got in this PR by accident again, like they did with your previous PR?

aik099 avatar Jan 08 '15 07:01 aik099

@aik099 gah they did... mmmm.. I think I going to need to delete my Mink repo and refork. Will that cause any issues? will it break the other PR?

I think I must of pushed the getComputedStyle onto my fork's master.

grom358 avatar Jan 09 '15 04:01 grom358

Okay I rebased onto upstream/master to solve for this PR

grom358 avatar Jan 09 '15 04:01 grom358

I think I going to need to delete my Mink repo and refork.

I think instead you should be pulling upstream/master into your fork's grom358/origin and then rebasing PR on top of that.

I think I must of pushed the getComputedStyle onto my fork's master.

That's bad news.

Okay I rebased onto upstream/master to solve for this PR

Unfortunately GitHub says otherwise because it can't automatically merge this PR.

aik099 avatar Jan 09 '15 07:01 aik099

Okay I rebased onto upstream/master to solve for this PR

I guess you forgot to fetch upstream first, so using an outdated upstream/master

stof avatar Jan 09 '15 09:01 stof

My upstream was set to Behat/Mink ... problem solved.

grom358 avatar Jan 13 '15 23:01 grom358

These duplicate scrutinizer errors are bogus.

grom358 avatar Jan 13 '15 23:01 grom358

@grom358 we don't consider duplications as failure conditions (because we know it's bogus in several places). the failure condition is for coding styles issues

stof avatar Jan 14 '15 09:01 stof

@stof fixed the indenting issues... I had my editor on 2 space indents :S

grom358 avatar Jan 22 '15 23:01 grom358

Was there anything else required for this PR?

grom358 avatar Feb 04 '15 02:02 grom358

Maybe squash. @stof , do you see any other changes required before merging?

aik099 avatar Feb 04 '15 08:02 aik099

I have updated this PR for the 1.7 changes. Scrutinizer thinks code is duplicate but its not as far as I can tell. Just number of methods that look similar.

grom358 avatar Mar 03 '15 00:03 grom358