minj
MaxTools
I don't really like that this module is using an external API. This is not a ML model and can be calculated internally
I don't really like that this module is using an external API. This is not a ML model and can be calculated internally
Hi @minj. The idea to use an API is to avoid duplicate the code for perfect age. The next U21 world cup is really complex and a given player may have two perfect age use. In the future me and @kauefelipe would like to extend the integration between Foxtrick and MaxTools always using APIs. For example allowing at match's order page review a direct result estimation using https://ht-mt.org/match/result-estimation. We would like to extend the perfect age information adding not only "last match" but also "last complete phase" and informing the amount of training the player would accumulate less than one in real perfect age for the phase. So if we keep only one code that will be really interesting to avoid rework. This is the reason for the API approach.
Hi @minj.
Good afternoon. Did you see MaxDareDevil's justification for using an API? You could see the plugin code? It would be nice to have a solution since the old U20 that is on foxtrick is showing the wrong dates.
Apologies for the delay. I was not in a good place mentally for weeks. Please do not worry about that. I'm in hurry with RL issues as well. I will talk with @kauefelipe asap.
You could see the plugin code?
@kauefelipe I am not exactly sure, what you've meant here.
Btw, I'll ask for a CHPP feature to confirm this integration
Are you still interested in working on this?
I would specifically like to see these:
- CORS headers
- Link to Data/Privacy policy
Hello minj. I was on vacation last month and I couldn't get anything because I spent a lot of time traveling. I will try to make adjustments in the next few days.
@minj , I made some of the adjustments you asked for.
I'm new to Git and I'm still learning. I gave you permission in my repository if you want to make any adjustments directly.