foxtrick icon indicating copy to clipboard operation
foxtrick copied to clipboard

Add additional links modules

Open minj opened this issue 6 years ago • 4 comments

From: murko PostID: 16412248.762 To: LA-MJ Re: 16412248.761 Datetime: 2019-02-06 09:33 Message:

Could you please add the module Links[name] also to pages that doesn't have it already?

Even though there are no official links to add, I personally would like to add a few of my own.

Could be set to deactived as deault (as long as there are no official links)

The pages I would like to have the Links-module on

Dashboard: /MyHattrick/Dashboard.aspx

My cup page: /Club/Cup/Default.aspx?teamId=xxxxx

My transfer page: /Club/Transfers/?TeamID=xxxxx

My matches page: /Club/Matches/?TeamID=xxxxx

My training page: /Club/Training/Training.aspx?teamId=xxxxx

Youth finances: /Club/Youth/Finances.aspx

Tournaments: /Community/Tournaments/?teamId=xxxxx

minj avatar Feb 24 '19 10:02 minj

https://pastebin.com/fEUTRPW3

https://screenshotscdn.firefoxusercontent.com/images/b89f37f5-a0ef-47d7-a132-aa480c348f66.png

murko69 avatar Feb 24 '19 15:02 murko69

It's actually the stupid keeper links that are at fault. I'll push a dirty fix now but this is bound to keep breaking.

minj avatar Feb 24 '19 16:02 minj

Personally I don't even use the links on PlayerDetailPage. Only reason I noticed it didn't work properly was when I checked what pages did have the linksModule and what pages didn't yet have it, so that I coulds suggest it being put up on a few more pages :)

But.... guessing someone uses this so a dirty fix is better than no fix I guess. But if you can tell exactly what link(s) are at fault maybe that dev could fix 'em

murko69 avatar Feb 24 '19 18:02 murko69

I totally misunderstood. The dirty fix is live, so i also thought that the LinksModule was added to more pages as well. That was not the case - but since the issue is still open I'm guessing you are aware of that and I'm just the eager beaver here 🤣

murko69 avatar Feb 25 '19 22:02 murko69