Optional permission rewrite

[minj]

Original issue 1164 created by suokkos on 2013-12-08T14:05:19.000Z:

What steps will reproduce the problem?

1. Installing Foxtrick 0.14.0.12511 for Chrome
2. Browse to youth players page

What is the expected behaviour? What is the actual behaviour instead? You could provide a screenshot if necessary. Foxtrick fetches extra information from the youth club.

What is the version of the FoxTrick, your browser and operating system? Foxtrick 0.14.0.12511 Chrome 31.0.1650.63 Debian sid (linux)

Copy FoxTrick debug output on the page here (Enable debug output at main preferences tab of FoxTrick)

Not debug log but this should make it clear what goes wrong.

Foxtrick.entry.contentScriptInit log.js:87 request time: 100 - init time: 24 ms log.js:87 event.returnValue is deprecated. Please use the standard event.preventDefault() instead. run time: 171 ms | /Club/Players/YouthPlayers.aspx ?YouthTeamID=2186619 log.js:87 Sorry fucker, needs permission! log.js:87

I can provide debug log if that would help solving the issue. But I suspect I need log from the moment when Foxtrick is trying to enable the optional permission.

Please provide any additional information below. No request to htev seem to work either. I don't know optional_permissions functionality in manifest.json but it appears to me that those are broken on Chrome 31. manifest.json

Both youthclub and htev used to work a few weeks ago. I don't know exactly when that broke for me as I only noticed it today.

[minj]

Comment #1 originally posted by minj on 2013-12-08T16:03:38.000Z:

just open the foxtrick prefs and give permission

[minj]

Comment #2 originally posted by minj on 2013-12-08T21:34:09.000Z:

<empty>

Status: NeedsFeedback

[minj]

Comment #3 originally posted by suokkos on 2013-12-08T21:37:16.000Z:

So I have to save preferences manually even tough that settings has been activated already before.

It might be more intuitive if there was link/button/etc in the page that could use optional permissions for extra content. That could even just open special preference page with simple yes/no-dialog asking if user wants to give the extra permission to access the external website.

[minj]

Comment #4 originally posted by minj on 2013-12-08T21:41:12.000Z:

naturally, it has been lost if you removed foxtrick

and yes there should be a better way for this but we have so many things to do and so little time

[minj]

Comment #5 originally posted by minj on 2013-12-08T21:42:37.000Z:

renaming this

we need a better way to add them, use them, and prompt for them

Status: Accepted Labels: -Platform-All, Platform-Chrome

[minj]

Comment #6 originally posted by minj on 2013-12-08T21:47:14.000Z:

<empty>

Labels: Maintainability

[minj]

Comment #7 originally posted by minj on 2014-01-07T20:00:46.000Z:

<empty>

Labels: Preferences

[minj]

Comment #8 originally posted by minj on 2014-01-07T22:01:47.000Z:

#854 has been merged into this issue.

Cc: CatzHoek

[minj]

Comment #9 originally posted by minj on 2014-01-07T22:02:35.000Z:

<empty>

Labels: -Priority-Medium, Priority-Critical, Milestone-1.0

[minj]

see #1590

[minj]

Target version for permissions: FFv55

[minj]

blocks #1319

[minj]

blocks #1657