Thomas BERNARD

Results 292 comments of Thomas BERNARD

@irwir does it fixes your problem ?

@irwir the prototype has been unchanged for at least 13 years and never has been a problem. https://github.com/miniupnp/miniupnp/blame/master/miniupnpc/include/miniupnpc.h#L40 ```c char * simpleUPnPcommand(int, const char *, const char *, const char...

> > the prototype has been unchanged for at least 13 years and never has been a problem. > > For the last 6 years it was SOCKET; the link...

In fact the 1st argument should be removed. It is not used internally in miniupnpc. But I don't know how many external projects are using `upnpDiscoverDevice()` directly :(

> > In fact the 1st argument should be removed. It is not used internally in miniupnpc. > > Things may change in next versions, but this is the current...

Yes I see that passing a socket in first argument is indeed bugged. I guess I had written this function in order to be able to reuse the same socket...

Since which version dllwrap is deprecated ? :sweat_smile:

I really don't know why it doesn't work. Is there something happening before it stops working ? does it work again when you stop miniupnpd and start it again, or...

It looks like a non standard use of iTXT chunk by adobe. I checked that webbrowsers don't support it neither ...

OK the spec that explains `tiff:Orientation` is [here](https://developer.adobe.com/xmp/docs/XMPNamespaces/tiff/) https://github.com/adobe/XMP-Toolkit-SDK/tree/main/docs