Re-site code for member VPC NACLs

[dms1981]

User Story

As a Modernisation Platform Engineer I want to move the code that creates member VPC network ACLs So that all the code for the member VPCs is in one location

User Type(s)

Modernisation Platform Engineer

Value

Back during this issue we refactored our NACL code so far as it affected our member VPCs. It was originally thought that this would affect all of our member VPCs, but I later learned that it did not affect the platform VPCs.

With that in mind, and given that the platform VPCs were resolved via this issue there is no reason I can see that we should keep the NACL code for member VPCs in the main modernisation platform repository.

The end goal here is to take the NACL code in terraform/modules/vpc-nacls in the modernisation-platform repository and migrate it to the modernisation-platform-terraform-member-vpc repository.

Assumptions / Hypothesis / Questions / Unknowns

Definition of done

• [ ] NACL code migrated back into member VPC repository
• [ ] Refactored code applied without any functional changes
• [ ] another team member has reviewed
• [ ] tests are green
• [ ] UR test OR added to continual research plan

Reference

How to write good user stories

[SimonPPledger]

@dms1981 to add further clarification

[github-actions[bot]]

This issue is stale because it has been open 90 days with no activity.

[davidkelliott]

Possibly duplicate of #2403