modernisation-platform icon indicating copy to clipboard operation
modernisation-platform copied to clipboard

Features/instance scheduler role

Open gfou-al opened this issue 2 years ago • 2 comments

For the most part, it's a copy of the "member-access" role and the Instance Scheduler Lambda resources under the modernisation-platform-account.

gfou-al avatar Aug 16 '22 09:08 gfou-al

TFSEC Scan Success

Show Output

*****************************

TFSEC will check the following folders:
terraform/environments/bootstrap/delegate-access

*****************************

Running TFSEC in terraform/environments/bootstrap/delegate-access
Excluding the following checks: aws-ssm-secret-use-customer-key,github-repositories-private,aws-vpc-no-excessive-port-access,github-repositories-require-signed-commits
  timings
  ──────────────────────────────────────────
  disk i/o             585.697µs
  parsing              3.459700053s
  adaptation           1.884392ms
  checks               36.844143ms
  total                3.499014285s

  counts
  ──────────────────────────────────────────
  modules downloaded   5
  modules processed    9
  blocks processed     242
  files read           36

  results
  ──────────────────────────────────────────
  passed               1
  ignored              161
  critical             0
  high                 0
  medium               0
  low                  0


No problems detected!

tfsec_exitcode=0

Checkov Scan Success

Show Output

*****************************

Checkov will check the following folders:
terraform/environments/bootstrap/delegate-access

*****************************

Running Checkov in terraform/environments/bootstrap/delegate-access
Excluding the following checks: CKV_GIT_1,CKV_AWS_126
2022-08-16 09:37:33,321 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-cross-account-access?ref=v2.2.0:None (for external modules, the --download-external-modules flag is required)
2022-08-16 09:37:33,321 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/iam/aws//modules/iam-assumable-roles:~>5.0 (for external modules, the --download-external-modules flag is required)
2022-08-16 09:37:33,321 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/iam/aws//modules/iam-assumable-role:~>4 (for external modules, the --download-external-modules flag is required)
terraform scan results:

Passed checks: 32, Failed checks: 0, Skipped checks: 13


checkov_exitcode=0

CTFLint Scan Success

Show Output

*****************************

Setting default tflint config...
Running tflint --init...
Installing `aws` plugin...
Installed `aws` (source: github.com/terraform-linters/tflint-ruleset-aws, version: 0.15.0)
tflint will check the following folders:
terraform/environments/bootstrap/delegate-access

*****************************

Running tflint in terraform/environments/bootstrap/delegate-access
tflint_exitcode=0

github-actions[bot] avatar Aug 16 '22 09:08 github-actions[bot]

TFSEC Scan Failed

Show Output

*****************************

TFSEC will check the following folders:
terraform/environments/bootstrap/delegate-access

*****************************

Running TFSEC in terraform/environments/bootstrap/delegate-access
Excluding the following checks: aws-ssm-secret-use-customer-key,github-repositories-private,aws-vpc-no-excessive-port-access,github-repositories-require-signed-commits
Error: scan failed: github/workspace/terraform/environments/bootstrap/delegate-access/iam.tf:180,56-57: Missing newline after argument; An argument definition must end with a newline.
tfsec_exitcode=1

Checkov Scan Success

Show Output

*****************************

Checkov will check the following folders:
terraform/environments/bootstrap/delegate-access

*****************************

Running Checkov in terraform/environments/bootstrap/delegate-access
Excluding the following checks: CKV_GIT_1,CKV_AWS_126
2022-08-16 14:38:46,484 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-cross-account-access?ref=v2.2.0:None (for external modules, the --download-external-modules flag is required)
2022-08-16 14:38:46,484 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/iam/aws//modules/iam-assumable-roles:~>5.0 (for external modules, the --download-external-modules flag is required)
2022-08-16 14:38:46,484 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/iam/aws//modules/iam-assumable-role:~>4 (for external modules, the --download-external-modules flag is required)
2022-08-16 14:38:46,484 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-github-oidc-provider?ref=v1.1.0:None (for external modules, the --download-external-modules flag is required)
terraform scan results:

Passed checks: 4, Failed checks: 0, Skipped checks: 0, Parsing errors: 1


checkov_exitcode=0

CTFLint Scan Failed

Show Output

*****************************

Setting default tflint config...
Running tflint --init...
Installing `aws` plugin...
Installed `aws` (source: github.com/terraform-linters/tflint-ruleset-aws, version: 0.15.0)
tflint will check the following folders:
terraform/environments/bootstrap/delegate-access

*****************************

Running tflint in terraform/environments/bootstrap/delegate-access
Failed to load configurations; /github/workspace/terraform/environments/bootstrap/delegate-access/iam.tf:180,56-57: Missing newline after argument; An argument definition must end with a newline.:

[31mError[0m: Missing newline after argument

  on /github/workspace/terraform/environments/bootstrap/delegate-access/iam.tf line 180, in module "instance-scheduler-access":
 180:   count  = local.account_data.account-type == "member" [1;4m1[0m : 0

An argument definition must end with a newline.

tflint_exitcode=1

github-actions[bot] avatar Aug 16 '22 14:08 github-actions[bot]

TFSEC Scan Failed

Show Output

*****************************

TFSEC will check the following folders:
terraform/environments/bootstrap/delegate-access

*****************************

Running TFSEC in terraform/environments/bootstrap/delegate-access
Excluding the following checks: aws-ssm-secret-use-customer-key,github-repositories-private,aws-vpc-no-excessive-port-access,github-repositories-require-signed-commits
Error: scan failed: github/workspace/terraform/environments/bootstrap/delegate-access/iam.tf:180,56-57: Missing newline after argument; An argument definition must end with a newline.
tfsec_exitcode=1

Checkov Scan Success

Show Output

*****************************

Checkov will check the following folders:
terraform/environments/bootstrap/delegate-access

*****************************

Running Checkov in terraform/environments/bootstrap/delegate-access
Excluding the following checks: CKV_GIT_1,CKV_AWS_126
2022-08-17 08:57:07,510 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-cross-account-access?ref=v2.2.0:None (for external modules, the --download-external-modules flag is required)
2022-08-17 08:57:07,510 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/iam/aws//modules/iam-assumable-roles:~>5.0 (for external modules, the --download-external-modules flag is required)
2022-08-17 08:57:07,510 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/iam/aws//modules/iam-assumable-role:~>4 (for external modules, the --download-external-modules flag is required)
2022-08-17 08:57:07,510 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-github-oidc-provider?ref=v1.1.0:None (for external modules, the --download-external-modules flag is required)
terraform scan results:

Passed checks: 4, Failed checks: 0, Skipped checks: 0, Parsing errors: 1


checkov_exitcode=0

CTFLint Scan Failed

Show Output

*****************************

Setting default tflint config...
Running tflint --init...
Installing `aws` plugin...
Installed `aws` (source: github.com/terraform-linters/tflint-ruleset-aws, version: 0.15.0)
tflint will check the following folders:
terraform/environments/bootstrap/delegate-access

*****************************

Running tflint in terraform/environments/bootstrap/delegate-access
Failed to load configurations; /github/workspace/terraform/environments/bootstrap/delegate-access/iam.tf:180,56-57: Missing newline after argument; An argument definition must end with a newline.:

[31mError[0m: Missing newline after argument

  on /github/workspace/terraform/environments/bootstrap/delegate-access/iam.tf line 180, in module "instance-scheduler-access":
 180:   count  = local.account_data.account-type == "member" [1;4m1[0m : 0

An argument definition must end with a newline.

tflint_exitcode=1

github-actions[bot] avatar Aug 17 '22 08:08 github-actions[bot]

TFSEC Scan Failed

Show Output

*****************************

TFSEC will check the following folders:
terraform/environments/bootstrap/delegate-access

*****************************

Running TFSEC in terraform/environments/bootstrap/delegate-access
Excluding the following checks: aws-ssm-secret-use-customer-key,github-repositories-private,aws-vpc-no-excessive-port-access,github-repositories-require-signed-commits
Error: scan failed: github/workspace/terraform/environments/bootstrap/delegate-access/iam.tf:180,56-57: Missing newline after argument; An argument definition must end with a newline.
tfsec_exitcode=1

Checkov Scan Success

Show Output

*****************************

Checkov will check the following folders:
terraform/environments/bootstrap/delegate-access

*****************************

Running Checkov in terraform/environments/bootstrap/delegate-access
Excluding the following checks: CKV_GIT_1,CKV_AWS_126
2022-08-17 10:48:37,543 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-cross-account-access?ref=v2.2.0:None (for external modules, the --download-external-modules flag is required)
2022-08-17 10:48:37,544 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/iam/aws//modules/iam-assumable-roles:~>5.0 (for external modules, the --download-external-modules flag is required)
2022-08-17 10:48:37,544 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/iam/aws//modules/iam-assumable-role:~>4 (for external modules, the --download-external-modules flag is required)
2022-08-17 10:48:37,544 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-github-oidc-provider?ref=v1.1.0:None (for external modules, the --download-external-modules flag is required)
terraform scan results:

Passed checks: 4, Failed checks: 0, Skipped checks: 0, Parsing errors: 1


checkov_exitcode=0

CTFLint Scan Failed

Show Output

*****************************

Setting default tflint config...
Running tflint --init...
Installing `aws` plugin...
Installed `aws` (source: github.com/terraform-linters/tflint-ruleset-aws, version: 0.15.0)
tflint will check the following folders:
terraform/environments/bootstrap/delegate-access

*****************************

Running tflint in terraform/environments/bootstrap/delegate-access
Failed to load configurations; /github/workspace/terraform/environments/bootstrap/delegate-access/iam.tf:180,56-57: Missing newline after argument; An argument definition must end with a newline.:

[31mError[0m: Missing newline after argument

  on /github/workspace/terraform/environments/bootstrap/delegate-access/iam.tf line 180, in module "instance-scheduler-access":
 180:   count  = local.account_data.account-type == "member" [1;4m1[0m : 0

An argument definition must end with a newline.

tflint_exitcode=1

github-actions[bot] avatar Aug 17 '22 10:08 github-actions[bot]

TFSEC Scan Success

Show Output

*****************************

TFSEC will check the following folders:
terraform/environments/bootstrap/delegate-access

*****************************

Running TFSEC in terraform/environments/bootstrap/delegate-access
Excluding the following checks: aws-ssm-secret-use-customer-key,github-repositories-private,aws-vpc-no-excessive-port-access,github-repositories-require-signed-commits
  timings
  ──────────────────────────────────────────
  disk i/o             6.614245ms
  parsing              5.34931495s
  adaptation           2.30188ms
  checks               33.221609ms
  total                5.391452684s

  counts
  ──────────────────────────────────────────
  modules downloaded   6
  modules processed    10
  blocks processed     260
  files read           42

  results
  ──────────────────────────────────────────
  passed               1
  ignored              135
  critical             0
  high                 0
  medium               0
  low                  0


No problems detected!

tfsec_exitcode=0

Checkov Scan Success

Show Output

*****************************

Checkov will check the following folders:
terraform/environments/bootstrap/delegate-access

*****************************

Running Checkov in terraform/environments/bootstrap/delegate-access
Excluding the following checks: CKV_GIT_1,CKV_AWS_126
2022-08-18 07:45:13,520 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-cross-account-access?ref=v2.2.0:None (for external modules, the --download-external-modules flag is required)
2022-08-18 07:45:13,521 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/iam/aws//modules/iam-assumable-roles:~>5.0 (for external modules, the --download-external-modules flag is required)
2022-08-18 07:45:13,521 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/iam/aws//modules/iam-assumable-role:~>4 (for external modules, the --download-external-modules flag is required)
2022-08-18 07:45:13,521 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-github-oidc-provider?ref=v1.1.0:None (for external modules, the --download-external-modules flag is required)
terraform scan results:

Passed checks: 40, Failed checks: 0, Skipped checks: 13


checkov_exitcode=0

CTFLint Scan Success

Show Output

*****************************

Setting default tflint config...
Running tflint --init...
Installing `aws` plugin...
Installed `aws` (source: github.com/terraform-linters/tflint-ruleset-aws, version: 0.15.0)
tflint will check the following folders:
terraform/environments/bootstrap/delegate-access

*****************************

Running tflint in terraform/environments/bootstrap/delegate-access
tflint_exitcode=0

github-actions[bot] avatar Aug 18 '22 07:08 github-actions[bot]

TFSEC Scan Success

Show Output

*****************************

TFSEC will check the following folders:
terraform/environments/bootstrap/delegate-access

*****************************

Running TFSEC in terraform/environments/bootstrap/delegate-access
Excluding the following checks: aws-ssm-secret-use-customer-key,github-repositories-private,aws-vpc-no-excessive-port-access,github-repositories-require-signed-commits
  timings
  ──────────────────────────────────────────
  disk i/o             771.605µs
  parsing              7.321555048s
  adaptation           2.183313ms
  checks               46.439068ms
  total                7.370949034s

  counts
  ──────────────────────────────────────────
  modules downloaded   6
  modules processed    10
  blocks processed     260
  files read           42

  results
  ──────────────────────────────────────────
  passed               1
  ignored              135
  critical             0
  high                 0
  medium               0
  low                  0


No problems detected!

tfsec_exitcode=0

Checkov Scan Success

Show Output

*****************************

Checkov will check the following folders:
terraform/environments/bootstrap/delegate-access

*****************************

Running Checkov in terraform/environments/bootstrap/delegate-access
Excluding the following checks: CKV_GIT_1,CKV_AWS_126
2022-08-18 07:49:00,762 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-cross-account-access?ref=v2.2.0:None (for external modules, the --download-external-modules flag is required)
2022-08-18 07:49:00,762 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/iam/aws//modules/iam-assumable-roles:~>5.0 (for external modules, the --download-external-modules flag is required)
2022-08-18 07:49:00,763 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/iam/aws//modules/iam-assumable-role:~>4 (for external modules, the --download-external-modules flag is required)
2022-08-18 07:49:00,763 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-github-oidc-provider?ref=v1.1.0:None (for external modules, the --download-external-modules flag is required)
terraform scan results:

Passed checks: 40, Failed checks: 0, Skipped checks: 13


checkov_exitcode=0

CTFLint Scan Success

Show Output

*****************************

Setting default tflint config...
Running tflint --init...
Installing `aws` plugin...
Installed `aws` (source: github.com/terraform-linters/tflint-ruleset-aws, version: 0.15.0)
tflint will check the following folders:
terraform/environments/bootstrap/delegate-access

*****************************

Running tflint in terraform/environments/bootstrap/delegate-access
tflint_exitcode=0

github-actions[bot] avatar Aug 18 '22 07:08 github-actions[bot]