upgrade terraform EKS module

[razvan-moj]

We have it pinned at v17 (https://github.com/ministryofjustice/cloud-platform-infrastructure/blob/main/terraform/aws-accounts/cloud-platform-aws/vpc/eks/cluster.tf#L114) because v18 introduces breaking changes (https://github.com/terraform-aws-modules/terraform-aws-eks/releases/tag/v18.0.0) that basically require a cluster rebuild We need at least release v18.0.6 to try Graviton CPUs

A/C:

• figure out a way to upgrade without rebuilding live
• try to get as close to latest upstream (v18.23.0 at the time of writing) as possible without major component edits

[razvan-moj]

~waiting for https://us-east-1.console.aws.amazon.com/support/home?region=eu-west-2#/case/?displayId=10332130631&language=en~

[jakemulley]

I've told Dependabot to ignore major version 18.

[razvan-moj]

blocked by https://github.com/terraform-aws-modules/terraform-aws-eks/issues/1744 (closed without a solution)

[vijay-veeranki]

I worked on these changes following this info https://github.com/clowdhaus/eks-v17-v18-migrate

https://github.com/ministryofjustice/cloud-platform-infrastructure/compare/test-upgrade-eks-module?expand=1

This caused cluster not to be reachable with this issue: Your worker nodes do not have access to the cluster. Verify if the node instance role is present and correctly configured in the aws-auth ConfigMap.

We need to look for solution of cluster access using suggestions from here: https://github.com/bryantbiggs/terraform-aws-eks/blob/master/docs/UPGRADE-18.0.md https://github.com/terraform-aws-modules/terraform-aws-eks/issues/1744

[jakemulley]

v19.0.0 is also out now, which includes potential breaking changes.

[vijay-veeranki]

https://docs.google.com/document/d/1Nv1WsqdYMBzjpO8jfmXEqjAY5nZ9GYWUpNNaMJVJyaw/edit#

[vijay-veeranki]

Closing this as we have multiple ticktets to test it before applying to live