minishift-addons icon indicating copy to clipboard operation
minishift-addons copied to clipboard

addon for prometheus in openshift 3.7

Open durandom opened this issue 7 years ago • 3 comments

the current addon works for 3.6 - but for 3.7 we also need the node exporter and alert manager

durandom avatar Nov 24 '17 11:11 durandom

@durandom @jorgemoralespou Is there no way we can make the existing add-on to work for both 3.6 and 3.7?

LalatenduMohanty avatar Dec 21 '17 06:12 LalatenduMohanty

I cant think of a way how. 3.6 needs a different application template. Unless there is a way to conditionally run oc commands, I dont see how

durandom avatar Dec 21 '17 08:12 durandom

Unless there is a way to conditionally run oc commands

No such way as of now in add-on. I think we have two options at the moment:

  1. Keep separate addon folder for both version (Current PR behavior)
  2. One addon folder
    • We need one prometheus.addon and another prometheus.3.6.addon.example
    • Document how to use 3.6 version add-on

WDYT @LalatenduMohanty ?

brgnepal avatar Dec 27 '17 05:12 brgnepal