dynamic-admission-controllers not working with 3.11 and enabled "admission controller webhooks"

[matzew]

On Minishift with patched oc v3.11 binary, and a workaround to enable admission controller webhooks, the dynamic-admission-controllers addon is not working.

Work-around:

minishift openshift config set --target=kube --patch '{
    "admissionConfig": {
        "pluginConfig": {
            "ValidatingAdmissionWebhook": {
                "configuration": {
                    "apiVersion": "apiserver.config.k8s.io/v1alpha1",
                    "kind": "WebhookAdmission",
                    "kubeConfigFile": "/dev/null"
                }
            },
            "MutatingAdmissionWebhook": {
                "configuration": {
                    "apiVersion": "apiserver.config.k8s.io/v1alpha1",
                    "kind": "WebhookAdmission",
                    "kubeConfigFile": "/dev/null"
                }
            }
        }
    }
}'

See bugzilla why that is needed.

the deployment of the dynamic-admission-controllers are not working:

minishift addon apply dynamic-admission-controllers

gives me:

-- Applying addon 'dynamic-admission-controllers':
Enable required admission configs..Error applying the add-on: Error executing command 'ssh command error:
command : /var/lib/minishift/bin/oc ex config patch /var/lib/minishift/base/kube-apiserver/master-config.yaml.dac -p '{"admissionConfig": {"pluginConfig": {"MutatingAdmissionWebhook": {"configuration": {"apiVersion": "v1", "kind": "DefaultAdmissionConfig", "disable": false } }, "ValidatingAdmissionWebhook": {"configuration": {"apiVersion": "v1", "kind": "DefaultAdmissionConfig", "disable": false }}}}}' > /var/lib/minishift/base/kube-apiserver/master-config.new.yaml
err     : exit status 1
output  : error: merging an object in json but data type is not struct, instead is: map

[douglascamata]

@matzew thank you! I can confirm that this workaround also works with minishift + OC v3.10.