operator icon indicating copy to clipboard operation
operator copied to clipboard

SFTP Option should allow a separate file allowed to be configured from a secret.

Open Jeremy-Boyle opened this issue 1 year ago • 4 comments
trafficstars

Is your feature request related to a problem? Please describe. Currently the SFTP private key is not configurable and would like to provide my own private key. Currently the SFTP uses the same console tls for SFTP.

Describe the solution you'd like A value in the CRD that allows you to change the the value from a secret key / path , should automatically change the deployment and mount the secret to the path that is expected when provided.

Helm chart should also be updated to allow easy configuration of the tenants.

Describe alternatives you've considered Not using minio operator

Suggestion:

spec:
  features:
    enableSFTP: true
    sftp:
      secretName: secret-name
      secretKey: (Default if not provided private.key)

Open to suggestions / changes happy to do the PR to support this.

Jeremy-Boyle avatar Jan 04 '24 22:01 Jeremy-Boyle

See

https://github.com/minio/operator/blob/64cb15eb5d56d35a3d45027cb23caacdbdcc1e00/pkg/resources/statefulsets/minio-statefulset.go#L313-L322

Jeremy-Boyle avatar Jan 04 '24 22:01 Jeremy-Boyle

This is a very low priority for us. Feel free to work on this and send a PR yourself.

harshavardhana avatar Jan 04 '24 22:01 harshavardhana

We are going to keep it open, but we are still waiting for a PR if you have time to invest and thank you ❤️

cniackz avatar Apr 08 '24 16:04 cniackz

You can add a volume mount with the secret, won't that suffice?

george-zubrienko avatar May 31 '24 07:05 george-zubrienko