mint
mint copied to clipboard
Respect `SERVER_REGION` in more targets and fix various bugs
Hey everyone, I tried using the tool based on main but encountered various errors. I went through them and tried to fix the ones that are relevant to us.
Tbh, I am a bit confused by these errors as they are very surface level. Is the tool actively used inside the minio org?
Please also see the commit bodies as I included some info there.
Proposed changes:
- Respect
SERVER_REGIONenv variable inaws-sdk-go,aws-sdk-javaandversioningtarget - Add locationconstraint flag that is necessary when using the AWS CLI
- Remove a header that caused API errors in
aws-sdk-ruby. Please note that I have no idea what this header might be used for. Removing it might silently break some expectations. However, in it's current form I don't think the request ever succeeded. - Fix bugs inside
versioningtarget that caused API errors - The code removed here didn't make sense to me. Again, I am uncertain what this might be currently used for. Especially after setting a correct value for
ObjectLockLegalHoldStatusin line 263
Please ping me if I should give more context to the changes.