minsql icon indicating copy to clipboard operation
minsql copied to clipboard

The region of the server metabucket must be configurable

Open aead opened this issue 5 years ago • 4 comments

Currently the region of the meta bucket of the server is not configurable. Therefore, you cannot start MinSQL with a server meta bucket that does not match the (somehow) hard-coded value in meta.rs

Anyway, name does not seem to be a "good" identifier for specifying the region - in general.

aead avatar Jul 02 '19 10:07 aead

We should fetch this automatically using getBucketLocation there is no reason to enable this as configurable value.

harshavardhana avatar Jul 02 '19 15:07 harshavardhana

I was not able to get this to work with e.g. play until I fixed the code locally. Kept failing with invalid region error returned from the S3 server...

aead avatar Jul 02 '19 15:07 aead

That is because minio-rs still doesn't implement getBucketLocation I guess

harshavardhana avatar Jul 02 '19 15:07 harshavardhana

You may be right we may need this configurable, since meta bucket is perhaps created automatically by MinSQL so a region param is needed.

harshavardhana avatar Jul 02 '19 15:07 harshavardhana