allow renames() for inlined writes without data-dir

[harshavardhana]

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers under the terms of the Apache 2 license. By creating this pull request, I represent that I have the right to license the contributions to the project maintainers under the Apache 2 license.

Description

allow renames() for inlined writes without data-dir

Motivation and Context

data-dir not being present is okay. However, we can still rely on the rename() atomic call instead of relying on the xl.meta write, which may truncate the file incorrectly.

How to test this PR?

CI/CD should handle it

Types of changes

• [x] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Optimization (provides speedup with no functional changes)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• [ ] Fixes a regression (If yes, please add commit-id or PR # here)
• [ ] Unit tests added/updated
• [ ] Internal documentation updated
• [ ] Create a documentation update request here

[bh4t]

Can someone please review this?

[harshavardhana]

PTAL @vadmeste @poornas @krisis