minio icon indicating copy to clipboard operation
minio copied to clipboard

chore: change the constant number to const variable

Open fwx5618177 opened this issue 1 year ago • 2 comments

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers under the terms of the [Apache 2 license] (https://www.apache.org/licenses/LICENSE-2.0). By creating this pull request I represent that I have the right to license the contributions to the project maintainers under the Apache 2 license.

Description

  • Change the number to constant variable.

Motivation and Context

How to test this PR?

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [x] Optimization (provides speedup with no functional changes)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [ ] Fixes a regression (If yes, please add commit-id or PR # here)
  • [ ] Unit tests added/updated
  • [ ] Internal documentation updated
  • [ ] Create a documentation update request here

fwx5618177 avatar Aug 27 '23 09:08 fwx5618177

Please resolve the conflicts @fwx5618177 thank you

harshavardhana avatar Jan 24 '24 07:01 harshavardhana

Please resolve the conflicts @fwx5618177 thank you

Done.

fwx5618177 avatar Jan 24 '24 16:01 fwx5618177

I don't know why always mentioned errors

fwx5618177 avatar Mar 05 '24 04:03 fwx5618177

A random flyby commit doesn't add anything closing, as many such places need fixing. We would prefer this to be done by the MinIO team rather than externally.

harshavardhana avatar Apr 04 '24 06:04 harshavardhana

A random flyby commit doesn't add anything closing, as many such places need fixing. We would prefer this to be done by the MinIO team rather than externally.

Okie, but I prefer to join our community to optimize minIO

fwx5618177 avatar Apr 04 '24 06:04 fwx5618177