minio icon indicating copy to clipboard operation
minio copied to clipboard

Introduce disk io stats metrics

Open vadmeste opened this issue 3 years ago • 1 comments

Description

Read /proc/diskstats if available and get the metrics of all drives belonging to MinIO backend disks.

Depends on https://github.com/minio/madmin-go/pull/111

Motivation and Context

How to test this PR?

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Optimization (provides speedup with no functional changes)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [ ] Fixes a regression (If yes, please add commit-id or PR # here)
  • [ ] Documentation updated
  • [ ] Unit tests added/updated

vadmeste avatar Aug 10 '22 13:08 vadmeste

Please use v1.4.16 @vadmeste

harshavardhana avatar Aug 10 '22 19:08 harshavardhana

Please fix the conflicts @vadmeste

harshavardhana avatar Aug 11 '22 18:08 harshavardhana

Two tests are failing @vadmeste

  • one is generated code missing
  • another is cross compile

harshavardhana avatar Aug 12 '22 07:08 harshavardhana

PTAL at the conflicts @vadmeste

harshavardhana avatar Aug 16 '22 02:08 harshavardhana

Mint Automation

Test Result
mint-fs.sh :heavy_check_mark:
mint-gateway-s3.sh :heavy_check_mark:
mint-erasure.sh :heavy_check_mark:
mint-dist-erasure.sh :heavy_check_mark:
mint-compress-encrypt-dist-erasure.sh :heavy_check_mark:
mint-pools.sh :heavy_check_mark:
mint-large-bucket.sh :x: more...

15512-503b793/mint-large-bucket.sh.log:

Running with
SERVER_ENDPOINT:      minio-k8s6:32175
ACCESS_KEY:           minio
SECRET_KEY:           ***REDACTED***
ENABLE_HTTPS:         0
SERVER_REGION:        us-east-1
MINT_DATA_DIR:        /mint/data
MINT_MODE:            full
ENABLE_VIRTUAL_STYLE: 0
RUN_ON_FAIL:          0

To get logs, run 'docker cp :/mint/log /tmp/mint-logs'

(1/14) Running aws-sdk-go tests ... done in 6 seconds
(2/14) Running aws-sdk-java tests ... done in 1 seconds
(3/14) Running aws-sdk-php tests ... done in 44 seconds
(4/14) Running aws-sdk-ruby tests ... done in 5 seconds
(5/14) Running awscli tests ... done in 52 seconds
(6/14) Running healthcheck tests ... done in 0 seconds
(7/14) Running mc tests ... done in 25 seconds
(8/14) Running minio-go tests ... done in 1 minutes and 9 seconds
(9/14) Running minio-java tests ... done in 33 seconds
(10/14) Running minio-js tests ... FAILED in 2 minutes and 40 seconds
{
  "name": "minio-js",
  "function": "\"before all\" hook in \"Object Tags API with Versioning support\"",
  "duration": 106514,
  "status": "FAIL",
  "error": "Error: read ECONNRESET at TCP.onStreamRead (internal/stream_base_commons.js:209:20)"
}
(10/14) Running minio-py tests ... done in 1 minutes and 26 seconds
(11/14) Running s3cmd tests ... done in 26 seconds
(12/14) Running s3select tests ... done in 3 seconds
(13/14) Running versioning tests ... done in 3 minutes and 5 seconds

Executed 13 out of 14 tests successfully.

Deleting image on docker hub Deleting image locally

minio-trusted avatar Aug 16 '22 10:08 minio-trusted