mc icon indicating copy to clipboard operation
mc copied to clipboard
verified publisher icon minio

ping:support ping a specified node and remove duplicate port printing

Open dormanze opened this issue 10 months ago • 4 comments

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers under the terms of the Apache 2 license. By creating this pull request I represent that I have the right to license the contributions to the project maintainers under the Apache 2 license.

Description

The output of the ping command repeatedly displays port information. image You cannot ping a specific node. You can only view information about all nodes. image

Motivation and Context

When there are a large number of node, it is difficult to view the ping result of an node.

How to test this PR?

mc ping myminio --node minio-1.minio-headless.kube-system.svc.cluster.local:8989 image

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [x] Optimization (provides speedup with no functional changes)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [ ] Fixes a regression (If yes, please add commit-id or PR # here)
  • [ ] Unit tests added/updated
  • [ ] Internal documentation updated
  • [ ] Create a documentation update request here

dormanze avatar Feb 11 '25 06:02 dormanze

After I update your commit, my testcase fails to be executed. Can you help me fix the problem?@harshavardhana I'm very grateful.

dormanze avatar Feb 12 '25 10:02 dormanze

Sent fix in https://github.com/minio/mc/pull/5134

klauspost avatar Feb 12 '25 10:02 klauspost

@dormanze I believe I've asked you this before, but please stop merging master unless you have a build failure requiring a newer version or a merge conflict.

It just creates noise, and makes everything take longer since I have to re-review and manually approve to run tests every time.

klauspost avatar Feb 17 '25 11:02 klauspost

@dormanze I believe I've asked you this before, but please stop merging master unless you have a build failure requiring a newer version or a merge conflict.

It just creates noise, and makes everything take longer since I have to re-review and manually approve to run tests every time.

I'm sorry to bother you, but I'm habitually updating local code, and I'm going to break this bad habit.

dormanze avatar Feb 17 '25 11:02 dormanze