mc icon indicating copy to clipboard operation
mc copied to clipboard

Add trailing headers support

Open klauspost opened this issue 2 years ago • 5 comments

Description

Add trailing headers to requests when specified in config.

Requires https://github.com/minio/minio-go/pull/1705

How to test this PR?

Modify config:

		"mys3": {
			"url": "https://s3.amazonaws.com",
			"accessKey": "AKIA3WNQJCXE3JVMGFPN",
			"secretKey": xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx",
			"api": "s3v4",
			"path": "auto",
			"trailingHeaders":true
		},

Types of changes

  • [x] New feature (non-breaking change which adds functionality)

klauspost avatar Oct 12 '22 13:10 klauspost

Will get this reviewed by @abperiasamy if we are okay to make changes to config.json with new fields. Sorry for the delay.

harshavardhana avatar Nov 18 '22 20:11 harshavardhana

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Mar 18 '23 10:03 stale[bot]

Still valid needs discussion.

harshavardhana avatar Mar 18 '23 23:03 harshavardhana

Will discuss this with @abperiasamy next week and get this merged.

harshavardhana avatar Jun 03 '23 05:06 harshavardhana

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Sep 16 '23 23:09 stale[bot]