mc icon indicating copy to clipboard operation
mc copied to clipboard

mc anonymous does not work with --insecure flag

Open nagyv opened this issue 2 years ago • 4 comments

Expected behavior

mc anonymous get --insecure play/testnotebooks/test1.ipynb returns the same as mc anonymous get play/testnotebooks/test1.ipynb

Actual behavior

It returns mc anonymous --help

Steps to reproduce the behavior

  1. (optional) Find a file using mc ls -r play. I picked testnotebooks/test1.ipynb
  2. Check its permissions with mc anonymous get play/testnotebooks/test1.ipynb. The check works.
  3. Check its permissions with mc anonymous get --insecure play/testnotebooks/test1.ipynb
  4. The check fails

mc --version

Checked both:

  • mc version RELEASE.2022-02-16T05-54-01Z
  • mc version RELEASE.2022-02-26T03-58-31Z

System information

MacOS. mc installed using brew install minio/stable/mc

nagyv avatar Mar 02 '22 10:03 nagyv

@nagyv the command should be mc anonymous --insecure get play/testnotebooks/test1.ipynb as the help message indicates.

@harshavardhana it looks like rewriting anonymous to use cli command styles instead of manually parsing the command should fix it.

vadmeste avatar Mar 02 '22 13:03 vadmeste

@vadmeste Tested and it works. Feel free to close it as it seems to be invalid.

nagyv avatar Mar 02 '22 13:03 nagyv

@nagyv the command should be mc anonymous --insecure get play/testnotebooks/test1.ipynb as the help message indicates.

@harshavardhana it looks like rewriting anonymous to use cli command styles instead of manually parsing the command should fix it.

It is not done so to keep backwards compatibility AFAIK @vadmeste

harshavardhana avatar Mar 02 '22 16:03 harshavardhana

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jun 04 '22 03:06 stale[bot]

Fixed with this, https://github.com/minio/cli/pull/7

vadmeste avatar Sep 06 '22 15:09 vadmeste