kes icon indicating copy to clipboard operation
kes copied to clipboard

fix: Upgrade azserect client for AZURE

Open jiuker opened this issue 1 year ago • 7 comments

Upgrade azserect client How to test:

export ClientID=UUID
export EndPoint=url
export Secret=secret
export TenantID=tid
export ManagedIdentityClientID=micd
go test github.com/minio/kes/internal/keystore/azure

Once the verification is successful, I remove the redundant code fix https://github.com/minio/kes/issues/261

jiuker avatar Jan 11 '24 07:01 jiuker

Hey @aead can you please review this when you get a chance?

bh4t avatar Jan 23 '24 19:01 bh4t

@jiuker did you get the chance to test this with Azure ? let me know if you need any help in Azure

vadmeste avatar Jan 31 '24 17:01 vadmeste

@jiuker did you get the chance to test this with Azure ? let me know if you need any help in Azure

Yeah. Pre commit have test code. I have tested it. @vadmeste

jiuker avatar Feb 01 '24 02:02 jiuker

@aead we need to get this merged for a new kes release, so that we can move to a supported SDKs. Can you PTAL ?

harshavardhana avatar Feb 01 '24 08:02 harshavardhana

@aead can you please review this?

bh4t avatar Feb 13 '24 18:02 bh4t

@aead we need to migrate to new SDK previous one is unmaintained now.. its a security risk.

harshavardhana avatar Feb 20 '24 06:02 harshavardhana

Checking back again on this @aead let me know if you could look at this PR.

harshavardhana avatar Apr 04 '24 22:04 harshavardhana

https://github.com/minio/kes/pull/459 supersedes this PR, closing this one.

harshavardhana avatar May 03 '24 14:05 harshavardhana