console icon indicating copy to clipboard operation
console copied to clipboard

Deleted Object selection (Delete Marker)

Open prakashsvmx opened this issue 2 years ago • 6 comments

The deleted object row selection highlight needs a different highlight to differentiate a delete marker row. or we can indicate it as a delete marker in some way.

https://user-images.githubusercontent.com/23444145/158328751-8cedd558-69a8-41f7-9ae2-1582b895a2c7.mp4

@oscarocastellanos

prakashsvmx avatar Mar 15 '22 07:03 prakashsvmx

@prakashsvmx Agree. I was already working on this, please, take a look:

https://xd.adobe.com/view/598f4778-f7d9-45d4-88c6-96d1821bcf6b-0cdc/

oscarocastellanos avatar Mar 15 '22 15:03 oscarocastellanos

it was a very subtle color

dvaldivia avatar Mar 29 '22 16:03 dvaldivia

The latest version explorer already has those pills, but I think @prakashsvmx is talking about the background of the row @oscarocastellanos

Screen Shot 2022-03-29 at 9 51 22 AM

dvaldivia avatar Mar 29 '22 16:03 dvaldivia

@dvaldivia @prakashsvmx Yeah, let's use the same gray we use everywhere, to keep consistency. I think it's #FCFCFC. Here's how it would look Captura de Pantalla 2022-03-29 a la(s) 11 07 24

oscarocastellanos avatar Mar 29 '22 17:03 oscarocastellanos

The issue isnin 16th second in video. In the object list view with deleted objects on,

The row selection should differentiate the deleted object from the normal objcet.

prakashsvmx avatar Mar 29 '22 17:03 prakashsvmx

Ah, I saw the video and it was clearer @prakashsvmx. I think the pills should fix that, doesn't it @dvaldivia? We have the background color and the pill to reinforce the message. Once selected, it gains the same background color as the others but it keeps the pill to retain the message.

Other option is to not change the color of the selected text. So still gray, instead of blue but just bolded.

oscarocastellanos avatar Mar 29 '22 17:03 oscarocastellanos

This is how it looks right now:

Screenshot 2022-12-12 at 12 14 06 Screenshot 2022-12-12 at 12 13 47

bexsoft avatar Dec 12 '22 18:12 bexsoft

I think we should not use italics @bexsoft. While it looks functional here, we avoid italics in our branding as much as possible.

oscarocastellanos avatar Dec 15 '22 17:12 oscarocastellanos