gpt-2-simple icon indicating copy to clipboard operation
gpt-2-simple copied to clipboard

setup.py is missing tensorflow dependency

Open HitLuca opened this issue 4 years ago • 4 comments

when installing this package, no tensorflow dependency is installed, because it's missing in the setup.py script. Given that it is a mandatory requirement, having it defined and locked to be a version prior to 2.0.0 would solve a bunch of issues

HitLuca avatar Jul 16 '20 13:07 HitLuca

x2, would love a fix for this!!

jfrench206 avatar Jul 22 '20 04:07 jfrench206

Here you are @jfrench206, we just need to wait for a merge now

HitLuca avatar Jul 22 '20 09:07 HitLuca

Afaik this usually isn't done because tensorflow<2 is split into two versions, tensorflow and tensorflow_gpu, and adding one as a requirement restricts users to one or the other.

seanbow avatar Jan 05 '21 02:01 seanbow

I reckon that if the package by default uses tensorflow and the user then installs tensorflow_gpu on top of it, the project will use the gpu.

HitLuca avatar Jan 05 '21 09:01 HitLuca