v2 icon indicating copy to clipboard operation
v2 copied to clipboard

storage/parser: do not clean entry tags in storage module

Open rdelaage opened this issue 3 months ago • 4 comments

This is not really a bug, but en enhancement to improve code maintainability. Currently the cleaning of entry tags is done the storage module. This is not the relevant module. This should be done in the parser module. This would need a little refactoring.

rdelaage avatar Mar 24 '24 18:03 rdelaage

See https://github.com/miniflux/v2/pull/2556#discussion_r1536786760

rdelaage avatar Mar 24 '24 18:03 rdelaage

@jvoisin introduced it in the RSS module with #2567. It should be done also for JSON and Atom feeds. I think we can factorize by putting it in the miniflux.app/v2/internal/reader/parser module, at the end of the ParseFeed function.

rdelaage avatar Mar 25 '24 06:03 rdelaage

reader/json is already taking care of it, and so does reader/atom

jvoisin avatar Mar 25 '24 23:03 jvoisin

Oh didn't know, but we still need to factorize it, this avoid code duplication and if a new type of feed is added it ensure it follows Miniflux standards

rdelaage avatar Mar 26 '24 18:03 rdelaage