v2 icon indicating copy to clipboard operation
v2 copied to clipboard

Upgrade to the new Shiori API once released

Open fierceX opened this issue 1 year ago • 11 comments

Update the api of shiori. The current api has been abandoned and doesn't work on the latest version of shiori. You want to update the api of shiori.

https://github.com/go-shiori/shiori/blob/master/docs/APIv1.md

fierceX avatar Sep 14 '23 10:09 fierceX

The Miniflux integration is tested against the latest stable version of Shiori which is currently v1.5.5 at the time of writing this comment.

The new Shiori API could be implemented in Miniflux after the Shiori authors release a new stable version.

fguillot avatar Sep 15 '23 02:09 fguillot

APIv1 is mentioned in the release notes of Shiori v1.6.0. However, it doesn't seem stable quite yet (it mentions running legacy and new APIs at the same time). Hopefully it will stabilize soon, as the Miniflux integration doesn't seem to work for this version.

cendenta avatar Mar 28 '24 11:03 cendenta

Old api is still working (for now) with a new endpoint, is a easy patch: https://github.com/mateusjdev/miniflux/commit/53f2c4f3111fb267d610174cf7bcb745a6371a94 but it will fail with Shiori v1.5.5 or older

mateusjdev avatar Apr 03 '24 03:04 mateusjdev

The Miniflux integration is tested against the latest stable version of Shiori which is currently v1.5.5 at the time of writing this comment.

The new Shiori API could be implemented in Miniflux after the Shiori authors release a new stable version.

The new API was introduced to the current stable release which currently is v1.6.2. Is it possible to integrate adaptations to the new API structure to Miniflux?

essys avatar Apr 08 '24 14:04 essys

The new API was introduced to the current stable release which currently is v1.6.2. Is it possible to integrate adaptations to the new API structure to Miniflux?

It's possible but still not finished right now, on version v1.6.2 the new API endpoint doesn't support bookmark creation, in shiori roadmap it is planned to v1.9.0, then:

  • if you want "stable" shiori and miniflux integration, stay in shiori v1.5.5 (if you already upgraded to v1.6.1 and later, you cannot go back to v1.5.5 easily because of database migrations)
  • if you know how to compile miniflux, you can use v1.6.1 and later with this commits: https://github.com/mateusjdev/miniflux/commit/53f2c4f3111fb267d610174cf7bcb745a6371a94, https://github.com/mateusjdev/miniflux/commit/60e107458c67fe0bc80ee240174bf67003b5ff3d

mateusjdev avatar Apr 16 '24 18:04 mateusjdev

Old api is still working (for now) with a new endpoint, is a easy patch: mateusjdev@53f2c4f but it will fail with Shiori v1.5.5 or older

Any chance this can be merged to main? Shiori has moved to 1.7.0 version.

quaintdev avatar Aug 15 '24 07:08 quaintdev