v2
v2 copied to clipboard
miniflux
[wip] Support marking feed entries older than one day
One of the features I miss from Tiny Tiny RSS is the ability to mark all items in a feed as read older than a certain duration ago. It has a dropdown with 1 day / 7 day / 30 days options for each view, regardless of a single feed or a collection of feeds.
This is a very rough first take at supporting marking entries older than one day. In particular, this is useful for high-traffic feeds where the content becomes invalid after a period of time, such as those from forums such as RedFlagDeals.com.
I have a few questions I'd like feedback on:
- As a new contributor, I was a little confused when I started by reading https://miniflux.app/docs/api.html and then discovered that the UI has an entirely separate set of routes it uses. Should new work go against the
/v1/API, or should those docs be updated to indicate they're for the "public" API of miniflux only? - I didn't see any examples of POSTs with parameters used by the UI. If there's one, I'd appreciate a pointer, as I'm not sure if I should be using query parameters or a JSON object in the POST body.
- I'm open to suggestions on wording / positioning / etc of the new link. I feel like it doesn't scale well if we wanted to support multiple "time ago" options. I thought about setting the link text to just
(than 1 day), but I think that isn't good from an accessibility perspective.
Do you follow the guidelines?
- [ ] I have tested my changes
- [x] I read this document: https://miniflux.app/faq.html#pull-request
This would be a nice addition, but from a user (me!) point of view 1 day is too little. IMHO it would be more useful to have some duration like 7 days (a week). We could even make it user-configurable, but then it starts getting complicated. It's hard to agree on sensible defaults.
The way Tiny Tiny RSS worked is it was a dropdown with 1 day / 7 days / 30 days as options. That's probably my preferred UI, if it's OK to add a dropdown here.
That seems reasonable to me, and not complicated. I don’t think I’d ever use the 1 day option for individual feeds, but it would be very useful for categories. That said if it ends up being a drop down anyway, these 3 options are quite sensible.
Now you just have to convince @fguillot :)
The way Tiny Tiny RSS worked is it was a dropdown with 1 day / 7 days / 30 days as options. That's probably my preferred UI, if it's OK to add a dropdown here.
A dropdown should be ok. However, this menu is starting to get crowded. I'm open to suggestion to improve that.
A dropdown should be ok. However, this menu is starting to get crowded. I'm open to suggestion to improve that.
For computers, a hover dropdown menu like: https://www.w3schools.com/howto/howto_css_dropdown.asp seems aligned with the spirit of miniflux.
For mobile, maybe something similar but with an explicit touch?
Closing stale pull-request. Feel free to resubmit this PR rebased on main branch.