Markus Minichmayr comments

Results 16 comments of


                                            Markus Minichmayr

Properly deal with non-existent recurrences

Reconsidering the case again, I think this is a mistake in RFC 5545. I believe that 1) doesn't apply to DST changes, only to non-existent dates > Recurrence rules may...

TBD: Make parsing of CalDateTime strings more restrictive

> First of all: These changes are useful and should get merged. > > Deserialization of non-standard input: All kind of "silent corrections", even when they make perfect sense, may...

Implement GetHashCode and Equals in terms of the type hierarchy

@axunonb Agree that `Equals` doesn't make too much sense in many classes. Agree to your list. Maybe double-check which types we use `HashSet`, `Dictionary`, `OrderBy`, ... (ask CoPilot which others)...

Implement GetHashCode and Equals in terms of the type hierarchy

@pinkfloydx33 Maybe just serialize both and compare the strings?

Implement GetHashCode and Equals in terms of the type hierarchy

The reason why they have been removed is that its not always obvious what equality means. In your example of RecurrencePattern: are two instances still equal if any of the...

Replace public methods / properties using `DateTime` with `CalDateTime`

@axunonb I started some effort in this direction end of last year. See #704 and #705