Justinas Delinda
Justinas Delinda
> > Originally new files data would overwrite old ones, but that got lost when I changed things, since files rarely change ignoring existing files seems like a good idea...
@lennyanders could you check by how much https://github.com/minht11/local-music-pwa/pull/9 improves things? Moving diffing to web worker and using relative paths for comparison are still thing I would want to do.
I really like the approach of saving `directoryHandle` together with the file. Maybe [`directoryHandle.resolve()`](https://developer.mozilla.org/en-US/docs/Web/API/FileSystemDirectoryHandle/resolve) could be used to check if one directory is parent of the other?. That should be...
Opps didn't mean to close this. While performance is good enough for now it still can be improved. Sorry I only briefly looked at your repo before. The whole approach...
For the most part everything looks good and I think it's worth doing it. Storing relative paths as ids is great idea. Right now I have pending moderate code and...
That sounds like great idea. It most likely won't happen until next year tho.
It is not possible to customize individual items sizes.
@chansuke I have started implementing it, but haven't worked on it for a while so sure why not. One insight I can provide, that substring and slice are not identical...
If we are only including [unicorn/prefer-string-trim-start-end](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/prefer-string-trim-start-end.md) and [unicorn/prefer-string-slice](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/prefer-string-slice.md) under `useConsistentStringFunctions` I think it's fine to keep them together, documentation wise it wouldn't be that hard to explain, link to MDN...
Based on discussion on https://github.com/biomejs/biome/issues/3039#issuecomment-2148955700 this rule should be split into two separate ones. To allow easier implementation, documentation and being more consistent with other rules. Sorry for the trouble...