Minhan Cao
Minhan Cao
@karteekmurthys I see this piece of code on line 99 of MinMaxAggregates.cpp, would this already have taken care of it? ``` /// Override 'accumulatorAlignmentSize' for UnscaledLongDecimal values as it ///...
Hi @karteekmurthys, I have made the change that you have requested, please review when you can. thanks!
Hi @Yuhta , can you review this PR when you can please? Thanks!
@Yuhta I have ran locally the velox aggregation fuzzer test: min() function: command ran: ``` _build/debug/velox/functions/prestosql/fuzzer/velox_aggregation_fuzzer_test --seed 123456 --duration_sec 1200 --logtostderr=1 --minloglevel=0 --only min --v=1 2>&1 | tee agg_fuzzer_test_min_20mins.out ```...
@Yuhta Fixed the branch
@aditi-pandit Here is the result for the aggregation fuzzer test for arbitrary(): I ran `_build/debug/velox/functions/prestosql/fuzzer/velox_aggregation_fuzzer_test --seed 123456 --duration_sec 60 --logtostderr=1 --minloglevel=0 --only arbitrary --v=1 2>&1 | tee agg_fuzzer_test_arbitrary.out` I can...
@karteekmurthys Thank you for identifying the test failure above! I was wondering how the switch to aligned memory allocator should be approached or implemented? Would it be similar to what...
@karteekmurthys I have implemented the change above, how do I get the linux CircleCI test to run on this PR?
Hi @kagamiori @Yuhta , can you review this PR when you can please? Thanks!
@pramodsatya Ran the fuzzer for 1hr, it was able to run without any failures to stop it ``` I20240507 15:57:20.689369 14876119 WindowFuzzer.cpp:225] ==============================> Started iteration 6844 (seed: 2430860766) I20240507 15:57:27.666707...