Dominik Marczuk

Results 28 comments of Dominik Marczuk

OK, so we're down to the very essence of this post: fixing the typings in order to get Node + TS up and running with rot.js. I will have a...

Alright, it seems I cannot make it into anything meaningful. I wanted to reorganise the exports so that this code would be valid: ``` import * as ROT from "rot-js";...

>Do you wish to try how that would work for you? No. There's no need to provide a separate CommonJS set of files. As I said before, Node.js is more...

TL;DR: he location of `.d.ts` files relative to the `.js` counterparts is completely irrelevant. It is also irrelevant whether type declarations span a different number of files than `.js`. `package.json`...

Because they are not named. When importing a default export, you give it your own name. You can import it as `RecursiveShadowcasting` or as `Tiddlywinks` (this is different from aliasing!),...

No, this is not the same use case. Once you import an object, TypeScript will know what it's referencing. Using something that's not yet been imported is harder.

1. As explained in the issue you linked, eliminating default exports and replacing them with named ones allows the IDE to provide intellisense (code completion) and automatic imports. More on...

BTW, if you decide to phase away from default exports, I can also extend the PR to go through the entire codebase. I only included the FOV module because this...

+1 My thoughts exactly. I would strongly encourage changing the module name to just NgBsDaterangepicker or something along these lines.

@wpferguson >You're adding it to Exif.Photo.LensModel manually? Is this done prior to import? Yes, I add lens information and aperture information (if I have it written down or memorised). I...