minetest_game icon indicating copy to clipboard operation
minetest_game copied to clipboard

Rename "material" Brick to "material" Bricks

Open Tim79000 opened this issue 1 year ago • 9 comments

It doesn't make sense, because it isn't one brick, it's a block made of multiple.

Tim79000 avatar Feb 26 '23 21:02 Tim79000

First of all: Naming is always debatable. From a technical standpoint however, such a rename is not feasible since it would be breaking compatibility. An alias could be used to work around this to some extent, but still wouldn't preserve compatibility e.g. for raw node.name == "..." checks. It's simply not worth the breakage / effort just for "fixing" a name that "doesn't make sense" (to you).

appgurueu avatar Feb 26 '23 21:02 appgurueu

I mean, the name that is shown. In the sense that mese blocks used to be called simply "mese"

Tim79000 avatar Feb 27 '23 01:02 Tim79000

I don't mean the codename, the codename shouldn't get to be changed. Just the displayed name.

Tim79000 avatar Feb 27 '23 01:02 Tim79000

Ah okay, that would then be a trivial nonbreaking change (that said, we'd be introducing a display name - technical name inconsistency, which I'm not a fan of).

appgurueu avatar Feb 27 '23 09:02 appgurueu

Ok

2023-02-27, pr 10:35, Lars Müller @.***> rašė:

Reopened #3016 https://github.com/minetest/minetest_game/issues/3016.

— Reply to this email directly, view it on GitHub https://github.com/minetest/minetest_game/issues/3016#event-8613583185, or unsubscribe https://github.com/notifications/unsubscribe-auth/A6DOUJP4QU7KDDPDDA3MICTWZRYOPANCNFSM6AAAAAAVIVTM7Q . You are receiving this because you are subscribed to this thread.Message ID: @.***>

Naniono avatar Feb 27 '23 09:02 Naniono

But it's more of a logical consistency, due to it being more than one brick.

Tim79000 avatar Mar 02 '23 19:03 Tim79000

Mese blocks also have this inconsistancy, as previously stated.

Tim79000 avatar Mar 02 '23 19:03 Tim79000

---------- Forwarded message --------- Nuo: Tim79000 @.> Date: 2023-03-02, kt 20:27 Subject: Re: [minetest/minetest_game] Rename "material" Brick to "material" Bricks (Issue #3016) To: minetest/minetest_game @.> Cc: Naniono @.>, Comment @.>

Mese blocks also have this inconsistancy, as previously stated.

— Reply to this email directly, view it on GitHub https://github.com/minetest/minetest_game/issues/3016#issuecomment-1452436093, or unsubscribe https://github.com/notifications/unsubscribe-auth/A6DOUJOT2BD7FGEKUACJFDTW2DYBTANCNFSM6AAAAAAVIVTM7Q . You are receiving this because you commented.Message ID: @.***>

Naniono avatar Mar 02 '23 19:03 Naniono

We will also need to update translations.

VBPROGER avatar May 05 '23 09:05 VBPROGER