minetest_game icon indicating copy to clipboard operation
minetest_game copied to clipboard

Carts: Get rid of animation hack

Open appgurueu opened this issue 2 years ago • 4 comments

Fixes #2950; also fixes the visual aspect of #1927 - the player is now rotated:

Rotated player

  • [ ] offset the entity by +0.5 if rotated; as a bonus, this will also fix the previous incorrectly offset selection box

appgurueu avatar Jun 01 '22 18:06 appgurueu

I just wanted to give this my approal :thinking:

Unrelated some smooth animation would be nice in the future, poor Sam must have a headache after riding such a track: one

sfan5 avatar Jun 01 '22 18:06 sfan5

After the offset is added this will look definitely better than the current one. The patch is surprising simple.

@sfan5 The rotation (of the cart) is actually interpolated client-side. It's just rather fast. It can also be observed when punching a cart into the other direction due to the direction <---> yaw connection. https://github.com/minetest/minetest/blob/9fc018ded10225589d2559d24a5db739e891fb31/src/client/content_cao.cpp#L1133

SmallJoker avatar Jun 02 '22 19:06 SmallJoker

What's the status here?

sfan5 avatar Apr 08 '23 16:04 sfan5

What's the status here?

Not finished. I remember this not being as easy as applying the appropriate offset.

appgurueu avatar Apr 08 '23 16:04 appgurueu