minetest_game icon indicating copy to clipboard operation
minetest_game copied to clipboard

Ensure sign content is retained on dig

Open Panquesito7 opened this issue 2 years ago • 15 comments

I'm not sure if this is more of a bugfix or feature, but I don't see it as good if people can dig signs that have content. I was once making a building and destroyed a sign with important information by accident. I had a backup of the text, but for people that do not have a backup or if it's just a very important text, and they lose it, it'd be bad for our users.

What do you think? Thanks. 🙂 EDIT: I already have the code for this implementation.

Panquesito7 avatar May 19 '22 17:05 Panquesito7

Makes removing sings a bit more laborious, but I like the idea. What do you think about a button in the form to remove it?

debagos avatar May 19 '22 19:05 debagos

Makes removing sings a bit more laborious, but I like the idea. What do you think about a button in the form to remove it?

That'd be a good option as well so that you don't have to remove the whole text for all signs.

Panquesito7 avatar May 19 '22 19:05 Panquesito7

It would be better to save the sign text in the item metadata, and restore it when placed This is probably too close to a feature to be accepted by MTG though

rubenwardy avatar May 19 '22 21:05 rubenwardy

That's another good idea, but as you said not sure if that's considered a feature.

Panquesito7 avatar May 19 '22 21:05 Panquesito7

This is a feature request and should be rejected. Preventing players from digging signs, or adding ownership to signs is a gameplay change, not a bugfix. Use protection mods.

Wuzzy2 avatar May 24 '22 12:05 Wuzzy2

This is a feature request and should be rejected. Preventing players from digging signs, or adding ownership to signs is a gameplay change, not a bugfix. Use protection mods.

I believe you're misunderstanding the issue: This is not about protection but rather about accidentally digging your own signs, losing the text. Ruben has described the proper fix.

appgurueu avatar May 24 '22 12:05 appgurueu

This could be used for griefing, because it would take ages to remove a large number of signs one by one

thevbw avatar Jun 01 '22 12:06 thevbw

This could be used for griefing because it would take ages to remove a large number of signs one by one

I'm not really sure what you mean. Could you please explain?

Panquesito7 avatar Jun 01 '22 13:06 Panquesito7

Your feature request (again, note that MTG is currently in bugfix-only / maintenance-only mode) would basically lock signs like locked chests. It's not well-written either since you have written nothing about how to ensure backwards-compability, because it will be surprising if signs from old world are now suddenly locked.

Since MTG is currently not accepting new features anyway, I suggest using a mod for that instead.

Wuzzy2 avatar Jun 01 '22 16:06 Wuzzy2

Your feature request (again, note that MTG is currently in bugfix-only / maintenance-only mode) would basically lock signs like locked chests. It's not well-written either since you have written nothing about how to ensure backwards-compability, because it will be surprising if signs from old world are now suddenly locked.

Since MTG is currently not accepting new features anyway, I suggest using a mod for that instead.

But this isn't locking the signs to everyone and just the owners. This issue is about not being able to dig a sign if it has content, regardless if you're the owner or not. Currently, chests with content cannot be diggable regardless if they're the owner or not. That doesn't make it a locked chest. I'm trying to do the same functionality the chest has (a normal chest, not a locked chest). I think this is more of a bugfix rather than a feature, IMO.

I hope I get to understand. Thanks. :)

Panquesito7 avatar Jun 01 '22 16:06 Panquesito7

The vast majority of signs will have text on them, this will destroy user experience. Either signs should store their text in item meta and restore on place, or nothing should change. Preventing digging like this is not a good approach

rubenwardy avatar Jun 01 '22 17:06 rubenwardy

Slightly offtopic (re the protection issue): For consistency steel signs should perhaps be protected the same way steel doors are protected.

appgurueu avatar Jun 01 '22 17:06 appgurueu

The vast majority of signs will have text on them, this will destroy user experience. Either signs should store their text in item meta and restore on place, or nothing should change.

I'm starting to doubt the item meta approach because without registering a second item the two types of signs will be distinguishable only by their descriptions. This may get users wondering why they can't merge their sign stacks...

appgurueu avatar Jun 01 '22 17:06 appgurueu

Sorry, but all of this will just create a compatibility nightmare. There's a reason why MTG is in maintenance mode.

Wuzzy2 avatar Jun 01 '22 18:06 Wuzzy2

re griefing Could you please explain?

It would take a long time to fumble around in a GUI for each sign if someone spammed them

thevbw avatar Jun 02 '22 10:06 thevbw

Any updates on this, or is this going to be rejected? Thanks.

Panquesito7 avatar Oct 19 '22 01:10 Panquesito7

Marking this as a possible close as being an UX change it's pretty much an (albeit minor) feature request.

appgurueu avatar Oct 19 '22 08:10 appgurueu

This is clearly a feature IMO and should be rejected.

sfan5 avatar Oct 19 '22 12:10 sfan5