irrlicht icon indicating copy to clipboard operation
irrlicht copied to clipboard

Backport changes and extensions from Minetest

Open numberZero opened this issue 2 years ago • 5 comments

These were added before forking Irrlicht. Currently there is no point keeping them separate.

See also: minetest/minetest#13227

numberZero avatar Feb 18 '23 22:02 numberZero

This should be all that's left:

  • https://github.com/minetest/minetest/tree/master/src/irrlicht_changes
  • https://github.com/minetest/minetest/tree/master/src/gui

Not sure if it makes sense to move the src/gui/ stuff to Irrlicht either since it might be too integrated to MT. In fact it might not make sense to move anything back since Irrlicht is supposed to merged into MT not the other way around.

sfan5 avatar Feb 19 '23 00:02 sfan5

If the GUI stuff is all that is there, it may indeed make more sense to to move in the opposite direction: move all GUI stuff that MT still uses into MT, and drop GUI part here altogether.

numberZero avatar Feb 19 '23 13:02 numberZero

There is also src/irrlichttypes.h:

  • irr::core::roundingError<s16> ()
  • *_MIN, *_MAX

src/irrlicht_changes is GUI stuff only so it should likely merged into src/gui.

numberZero avatar Mar 13 '23 18:03 numberZero

irr_ptr would be good to have in irrlicht.

Desour avatar Mar 14 '23 18:03 Desour

irr_ptr would be good to have in irrlicht.

Makes sense. For the API I’d wait for The Merge but for internal use, it’s OK to start using it now IMO. My grep suggests there are 287 drop calls and 89 grab calls awaiting replacement.

numberZero avatar Mar 15 '23 15:03 numberZero