contentdb icon indicating copy to clipboard operation
contentdb copied to clipboard

Published 20 hours ago • verified publisher icon minetest

Addition of a link to release notes

Open dacmot opened this issue 2 years ago • 8 comments

Problem

I think a link to release notes would be a useful and informative addition. Similar to the website, repo, issue tracker and forums' links.

Solutions

Add a new field to the web form, database, cdb.json parser, and I would recommend displaying a "Changelog" link between "Source" and "Forums", and maybe also next to the "Versions" section.

Alternatives

Not adding a link?

Additional context

None.

dacmot avatar Oct 15 '23 20:10 dacmot

Hi, can I give this a shot?

Manish-Giri avatar Oct 16 '23 03:10 Manish-Giri

@Manish-Giri Hi, can I give this a shot?

Sure!

Take a look at how "website" is implemented for a guide.

You'll need to:

  1. Add a field to the Package table / model
  2. Create a migration
  3. Add a field to the PackageForm
  4. Use that field in logic / package
  5. Show it on templates / packages / view
  6. Add to api (done in get dictionary in the package model)

rubenwardy avatar Oct 16 '23 08:10 rubenwardy

@rubenwardy Thank you for sharing these steps, I'll get started on it!

Manish-Giri avatar Oct 18 '23 04:10 Manish-Giri

@rubenwardy I noticed some issues while running the steps in the Getting Started doc.

The containers that get created after running docker-compose are all named using -, while the shell scripts in utils seem to look for containers that are named using _. Here are some screenshots -

  1. Here are some of the running containers after running docker-compose up --build. Notice the name - contentdb-app-1 - Screen Shot 2023-10-18 at 9 05 29 PM

  2. The run_migration.sh script looks for a container called contentdb_app_1, which doesn't exist and so the command fails - Screen Shot 2023-10-18 at 9 09 15 PM

  3. If I manually rename the name in run_migration.sh, same behavior is seen in the next step, in bash.sh - Screen Shot 2023-10-18 at 9 13 41 PM

  1. If I make these manual modifications, things seem to be working - Screen Shot 2023-10-18 at 9 23 47 PM

Manish-Giri avatar Oct 19 '23 02:10 Manish-Giri

I think it's failing in Step 2 now

Screen Shot 2023-10-18 at 10 09 15 PM

Manish-Giri avatar Oct 19 '23 03:10 Manish-Giri

Yeah, if you're using a newer version of docker-compose you need to use - and not _

rubenwardy avatar Oct 19 '23 09:10 rubenwardy

Note, as of https://github.com/minetest/contentdb/commit/4ef3aae193ddf5f2564c87a1ddb0d79037d784b9 the - vs _ issue is fixed

rubenwardy avatar Dec 15 '23 23:12 rubenwardy

Thank you, I'll get back on this

Manish-Giri avatar Dec 16 '23 05:12 Manish-Giri

Just wanted to say thank you @Manish-Giri and @rubenwardy ! The new release notes panel looks great!

dacmot avatar Jul 11 '24 02:07 dacmot