mesecons icon indicating copy to clipboard operation
mesecons copied to clipboard

Add static middle vertical wire

Open Desour opened this issue 5 years ago • 7 comments

This is highly related to and closes #480. (Sorry that I'm opening a second PR, FranchuFranchu.)

What this PR adds / changes / does and other notes:

  • Everything is tested and works fine.
  • The vertical bottom is visually insulated at the bottom.
  • One new conductor: the static middle vertical wire
  • It can be crafted.
  • It can be rotated (wallmounted).
  • Vertical mesecons connects to it if it's rotated up or down.
  • It can receive signals from buttons and co.
  • Using it should be pretty easy for players.

Desour avatar Sep 17 '19 23:09 Desour

I've done some small improvements and fixes.

Desour avatar Sep 18 '19 14:09 Desour

Would someone like to review or test please btw.?

Desour avatar Dec 27 '19 00:12 Desour

I use it since the beginning... It work great and it's really useful. I'm not so sure why nobody merged it already. Do it need more review or somebody with some administration privilege or something else?

Digiline also provide a block with the same feature would be nice if Mesecon had it by default too.

leucome avatar Dec 30 '19 08:12 leucome

I use it since the beginning... It work great and it's really useful.

That's nice to hear!

Do it need more review or somebody with some administration privilege or something else?

Somebody would have to review and someone would then have to merge.

Digiline also provide a block with the same feature

What are you referring to? It's probably a digiline expansion, isn't it?

Desour avatar Dec 30 '19 14:12 Desour

What are you referring to? It's probably a digiline expansion, isn't it?

You are right it come with an other mod called digistuff.

leucome avatar Dec 30 '19 15:12 leucome

Rotation is broken: the nodes aren’t updated when they should, and even when they are, some combinations are still problematic.

Conductive Air Power Mesecon
screenshot_20200628_011651 screenshot_20200628_012143

numberZero avatar Jun 27 '20 22:06 numberZero

Thanks for testing!

The left thing is actually intended. Otherwise it would be weird if there was a mese block and it didn't connect. I know, this is ugly, but player might be used to such connections anyway (eg. from the pipeworks connecting tubes).

I've tried to fix the right thing, but I couldn't get it working correctly. Therefor I've just disabled rotation of active wire.

(I've also rebased.)

Desour avatar Jun 28 '20 12:06 Desour