craftguide icon indicating copy to clipboard operation
craftguide copied to clipboard

Craftguide inventory graphical issue

Open orbea opened this issue 4 years ago • 8 comments

minetest: 5.2.0 craftguide: https://github.com/minetest-mods/craftguide/commit/8c7408f66f0483ff064f004b29dc69de158b3a74

When using the craftguide book or sign the arrows are overlapping with the number of usages or recipes. While its still usable, its distracting and much harder to read unlike the screenshot shown in the README.md file.

I can reproduce this with minetest_game and no other mods, is there anything that can be done to resolve this?

1

orbea avatar Apr 09 '20 14:04 orbea

I'm waiting https://github.com/minetest/minetest/pull/8658 to be merged to fix that. Current label wrapping doesn't care about font size.

kilbith avatar Apr 09 '20 14:04 kilbith

Ah, thanks for explaining. Do you know what the current delay with that PR is? Could it be potentially backported to a server build or is it client side?

orbea avatar Apr 09 '20 14:04 orbea

Both the server and client need it. Ask @rubenwardy for a review.

kilbith avatar Apr 09 '20 14:04 kilbith

Why not just giving the text more space to breathe in the meantime? Will also benefit translations which are usually more verbose than English.

Wuzzy2 avatar Apr 16 '20 11:04 Wuzzy2

The proper fix is to have the label aligned on the right and put it outside between the buttons.

kilbith avatar Apr 16 '20 11:04 kilbith

Text has been granted more space (good if you're german) but this doesn't into account the font size yet.

kilbith avatar Jul 10 '20 13:07 kilbith

https://github.com/minetest-mods/craftguide/commit/00dcea5c50240e0ab50f1b97b55676e4a7d4f553 should resolve the labels overlapping but you need to use Minetest 5.4-dev.

kilbith avatar Jul 15 '20 00:07 kilbith

Thanks for the continued attention, I'm not currently playing minetest so I'm not sure when I will be able to test this. Feel free to close this issue when you find best, I would suggest perhaps when this is fixed in a stable minetest release?

orbea avatar Jul 15 '20 02:07 orbea