terraform-github-repository icon indicating copy to clipboard operation
terraform-github-repository copied to clipboard

Add support for configuring default squash and merge commit titles and messages

Open soerenmartius opened this issue 3 years ago • 7 comments

soerenmartius avatar Oct 25 '22 18:10 soerenmartius

@mariux is this good to go?

soerenmartius avatar Nov 02 '22 11:11 soerenmartius

@mariux the tests are failing after applying your provided suggestions ... not a priority though https://github.com/mineiros-io/terraform-github-repository/actions/runs/3394710192/jobs/5643646371

soerenmartius avatar Nov 04 '22 14:11 soerenmartius

Is this ready to be merged?

anthr76 avatar Dec 29 '22 17:12 anthr76

Is this PR still actually a draft, or once conflicts are resolved, is it ready for approval and merging? Githubs default squash strategy grinds my gears.

Thanks

gaima8 avatar Apr 12 '23 09:04 gaima8

Would be good to get this over the line. I can't even manually tweak the repository settings as the current release of this module resets the squash settings back to the defaults.

bodgit avatar Jul 27 '23 13:07 bodgit

I think this PR might be ready to review?

marcjay avatar Aug 21 '23 16:08 marcjay

Hello all! What is the ETA on merging this one? We forked it for the time being just for this PR and it seems to work as expected.

marko-fabry avatar Oct 09 '23 10:10 marko-fabry