terraform-github-repository icon indicating copy to clipboard operation
terraform-github-repository copied to clipboard

Published 20 hours ago • verified publisher icon mineiros-io

feat: add v4 branch protections

Open taharah opened this issue 2 years ago • 3 comments

Adds v4 branch protections as a separate resource. If v4 branch protections are set, then it will disable the v3 branch protection resource to prevent any conflicts.

Resolves #124

Signed-off-by: Trevor Wood [email protected]

taharah avatar Sep 02 '22 19:09 taharah

This appears to need a rebase.

anthr76 avatar Sep 29 '22 21:09 anthr76

@taharah do you have time to get this ready for review? This would be helpful for my team. If now I’m happy to take it over.

kevcube avatar Oct 20 '22 19:10 kevcube

Also - optional attrs came out of preview so that part can be removed! (Min tf version will need to be bumped up)

kevcube avatar Oct 20 '22 19:10 kevcube

Also - optional attrs came out of preview so that part can be removed! (Min tf version will need to be bumped up)

I'll get this updated tonight for TF 1.3+. On another note, should this continue to maintain backwards compatibility for v3 protections, or would a breaking change with the appropriate version bump be acceptable?

taharah avatar Oct 26 '22 21:10 taharah

@anthr76 or @kevcube this has been updated and is ready for review.

taharah avatar Oct 31 '22 21:10 taharah

I am not a maintainer of this repo, though I'm happy to give it a second set of eyes.

anthr76 avatar Oct 31 '22 22:10 anthr76

I'm not a maintainer either. Only a happy user, and hopefully also able to help to get this into the main branch.

jvandijk avatar Oct 31 '22 22:10 jvandijk

hey guys, sorry for the delay! We'll review this shortly and come back to you!

soerenmartius avatar Nov 01 '22 00:11 soerenmartius

@mariux or @soerenmartius would it be possible to get a review please?

taharah avatar Nov 02 '22 02:11 taharah

sorry for the delay... we added the provided feature but in a slightly different way to support computed values in some scenarios also restoring terraform 1.0 compatibility.

We just released the new version.

Thanks again for providing the feature.

mariux avatar Nov 07 '22 20:11 mariux

Thank you @mariux & @taharah . I've updated my configuration to match your changes and bumped to v0.18.0!

jvandijk avatar Nov 08 '22 12:11 jvandijk