mcpelauncher-manifest icon indicating copy to clipboard operation
mcpelauncher-manifest copied to clipboard

Published 20 hours ago • verified publisher icon minecraft-linux

Held Keybinds: Enter Key Releases Automatically

Open Offroaders123 opened this issue 2 years ago • 3 comments

Describe the bug When setting a "held keybind" to be activated by the Enter/Return key, the action is released after a short period of time. A few examples of some "held keybind" actions include the Move Forwards, Move Left, and Sneak/Fly Down options.

To Reproduce Steps to reproduce the behavior:

  1. Go to 'Settings', either on the Start menu or while in gameplay through the Pause menu.
  2. Click on the 'Keyboard & Mouse' settings tab.
  3. Scroll down to the 'Sneak/Fly Down' keybind. Click on the keybind option that lists the current keybind, then press your 'Enter/Return' key to set the keybind to use 'Enter/Return'.
  4. Go (back) into a world, and hold down your 'Enter/Return' key to activate 'Sneak' or 'Fly Down'. Notice that after about a half-second or so, 'Sneak/Fly Down' will be released even though you are still holding down the 'Enter/Return' key.

Expected behavior Holding down the 'Enter/Return' key should not release after a short period of time.

Screenshots Sneak/Fly Down Keybind Section

Desktop

  • OS: macOS
  • Version: v0.3.4-macOS-x86_64-0.2.361 (build 361)
  • Installation Type: dmg

Additional context I first stumbled across this issue while playing on macOS. I later hopped over to Linux and native Bedrock on Windows to check if it was present on those platforms as well, and it wasn't. It appears to be something related to macOS specifically.

Offroaders123 avatar Apr 09 '22 06:04 Offroaders123

Seems to be specfic to the glfw window provider of this launcher on both linux and macOS.

ChristopherHX avatar Apr 09 '22 19:04 ChristopherHX

Is there a possible way to fix it? I can try to add a patch too if it's hard to find where it's at.

Offroaders123 avatar Apr 25 '22 18:04 Offroaders123

Is there a possible way to fix it?

Very likely, because the linux eglut window provider doesn't have this bug.

The bug must be somewhere in this file ( or in the glfw library ) https://github.com/minecraft-linux/game-window/blob/master/src/window_glfw.cpp

If you clone this github project recursively you already have a checkout of game-window.

I'm the only semi active contributor, contributions are welcome. I'm focusing on other projects

Edit: In eglut you cannot type chars by holding a button, while it works in glfw

ChristopherHX avatar Apr 25 '22 18:04 ChristopherHX