MinecraftDev icon indicating copy to clipboard operation
MinecraftDev copied to clipboard

"Minecraft Class" helpers do not support Mojang's official mappings

Open ChloeDawn opened this issue 4 years ago • 4 comments

2020.2-1.5.2

In a Fabric environment that uses official mappings, the helper attempts to use Yarn mappings.

mappings(minecraft.officialMojangMappings())

It should be using the mappings configured for the current workspace.

Screenshot of new object tooltip Screenshot of class creation modal Screenshot of resulting class

ChloeDawn avatar Dec 27 '20 17:12 ChloeDawn

This was a feature I implemented, and I obviously didn't realise the mapping differences at the time. You should be able to adjust the templates if you want by going to Settings -> Editor -> File and Code Templates and then Skeletons under the Minecraft dropdown.

The reason it doesn't use the current mappings is that the template is predefined. I should probably work on it remapping the templates as it places them into a project or something similar.

Tom-The-Geek avatar Dec 27 '20 17:12 Tom-The-Geek

Yeah, seems to me that the template should be in intermediary mappings and then resolved when created.

jamierocks avatar Dec 27 '20 22:12 jamierocks

Yeah, that's something we'll be able to do somewhat soon, once my overall mappings handling rewrite is done. Until then, editing the template is the best route.

DenWav avatar Dec 27 '20 22:12 DenWav

Related to #771

Earthcomputer avatar Dec 27 '20 23:12 Earthcomputer