Osclass icon indicating copy to clipboard operation
Osclass copied to clipboard

Show e-mail checkbox is always enabled

Open navjottomer opened this issue 2 years ago • 2 comments

In the new version of the site, the Show e-mail checkbox is always enabled, it cannot be turned off even by the administrator.

Originally posted by @buninsan in https://github.com/mindstellar/Osclass/discussions/435#discussioncomment-1659984

navjottomer avatar Nov 18 '21 01:11 navjottomer

@buninsan Does this fix work for you?

eurobank avatar Nov 19 '21 10:11 eurobank

This fixed the "always enabled" but there's still problems with how value is read from session. For me it now always kept it unchecked.

if (Session::newInstance()->_getForm('showEmail') != 0) should probably be if (Session::newInstance()->_getForm('showEmail') != "") in show_email_checkbox.

patriksh avatar Dec 27 '21 12:12 patriksh